GithubHelp home page GithubHelp logo

Comments (5)

saghul avatar saghul commented on June 12, 2024 1

Thanks for getting the ball rolling @davidliu and for the pointer @8BallBomBom!

I'm going to start preparing a new build this week. I think we need 2 things here:

  1. The WebRTC framework itself should have one, since we publish it on CocoaPods, and it's also consumed by Flutter for example.

  2. What @8BallBomBom mentioned should work for RN apps, but in the interest of helping others we can document it too.

from react-native-webrtc.

saghul avatar saghul commented on June 12, 2024

I pushed a build last week no problem, but that was using Xcode 14, maybe that's why I didn't even get a warning.

Thanks for looking into this.

I guess it's a good time to update WebRTC and make a new build then!

from react-native-webrtc.

davidliu avatar davidliu commented on June 12, 2024

So I tried adding the privacy manifest file, but I'm not actually sure if it's working. Generating a privacy report ends up with an empty pdf. At the very least, XCode detects that the privacy files exist, since when none are added, it refuses to generate a report. I'll need someone to test and make sure it's not just my XCode acting weird.

To test, there's two ways, adding to react-native-webrtc or the underlying WebRTC framework:

Adding to react-native-webrtc

  1. Copy the privacy file into node_modules/react-native-webrtc/ios/
  2. Add the following line to the podspec:
 s.resource_bundles = {"react-native-webrtc" => ["ios/PrivacyInfo.xcprivacy"]}
  1. In your app's ios folder, pod install
  2. Archive and generate privacy report.

Adding to the WebRTC framework

  1. Copy the privacy file, go to node_modules/ios/Pods/JitsiWebRTC/WebRTC.xcframework, and paste in all the ios-platform/WebRTC.framework folders.
  2. Archive and generate privacy report.

@saghul looks like this just landed on the upstream repo: https://webrtc-review.googlesource.com/c/src/+/349440

from react-native-webrtc.

8BallBomBom avatar 8BallBomBom commented on June 12, 2024

Something related has been pushed out with React Native 0.74.1 over here.
Hopefully that gets back ported a little 😅

from react-native-webrtc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.