Not passing themes to muiTheme() causes rendering errors about storybook-addon-material-ui

[bareynol]

doing some digging into this myself. I'll see if I can fix it and submit a PR

[bareynol]

It seems that when custom themes are passed in via .storybook/stories.js, only the object which specifies the MUI overrides are used:

https://github.com/react-theming/storybook-addon-material-ui/blob/version-1/.storybook/stories.js#L27

import { overridings as theme1 } from './.themes/customTheme1';
import { overridings as theme2 } from './.themes/customTheme2';
import themeF3, { overridings as theme3 } from './.themes/customTheme3';
import { overridings as theme4 } from './.themes/customTheme4';
import { overridings as theme5 } from './.themes/customTheme5';

...
  .addDecorator(muiTheme([theme1, theme2, theme3, theme4, theme5]))
...

overriding object can be found here: https://github.com/react-theming/storybook-addon-material-ui/blob/version-1/.storybook/.themes/customTheme1.js#L15

---

In the muiTheme() definition, while themes received are objects, the default lightBaseTheme and darkBaseTheme are created using createMuiTheme()

I believe this is presenting an issue in the FullTheme component and causing a crash because this component calls createMuiTheme() on the currently selected theme when sending it to the object inspector:

https://github.com/react-theming/storybook-addon-material-ui/blob/version-1/src/UI/FullTheme.js#L31

Calling createMuiTheme twice on a set of overrides causes the same error as listed above.

[bareynol]

Removing createMuiTheme() on the default light/dark themes and adding palette: { type: 'light' } to the lightBaseTheme configuration did the following for me on a local build:

1. stopped the app from crashing when selecting "full theme" in the addon panel
2. fixed the default dark theme not being applied to components in storybook

[bareynol]

I think part of my issue overall is that I was using material-ui/core v4, whereas, from what I can tell, this repo only supports Material-ui v3 (though that doesn't appear to be documented anywhere).

So it seems like this addon uses MuiThemeProvider as a decorator, and not the ThemeProvider introduced in v4.

[rvillalba-novetta]

Same observations here. Button on the right seems to imply that its v3 as well thought I wasn't sure at first. This should be documented in the README. Support for v4 would be great.