GithubHelp home page GithubHelp logo

Comments (8)

zenweasel avatar zenweasel commented on April 27, 2024 2

@MohanNarayana what @karaarda is referring to is that our code is using the version of the schema directly imported from the original definition, not the version that gets extended which is available via the context, therefore even when properly extended schema validation will fail. I think they properly suggest the fix there which is to change the validation in the cart code to use the extended schema via the context. This should be best practice everywhere.

from api-plugin-carts.

MohanNarayana avatar MohanNarayana commented on April 27, 2024 1

All validation is done against simpleSchema. The same schema is available via context. Any change in schema that has to be validated should be added/updated to simpleSchema.js

from api-plugin-carts.

karaarda avatar karaarda commented on April 27, 2024 1

The one I shared in the original post is a valid solution I think.

After trying to find someone to get in touch for a year without luck and finding ourselves re-writing or overriding almost everything, reaction commerce costed us a lot.

from api-plugin-carts.

zenweasel avatar zenweasel commented on April 27, 2024 1

@karaarda Would you be willing to talk to me about your experiences? https://discord.gg/aqnvYFZc

from api-plugin-carts.

karaarda avatar karaarda commented on April 27, 2024

It does not matter for me anymore to be honest.

from api-plugin-carts.

zenweasel avatar zenweasel commented on April 27, 2024

Is that because you are no longer using Open Commerce? Or you found another solution?

from api-plugin-carts.

rc-publisher avatar rc-publisher commented on April 27, 2024

🎉 This issue has been resolved in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

from api-plugin-carts.

karaarda avatar karaarda commented on April 27, 2024

@zenweasel joined the discord server but couldn't find you. feel free to find me in the server and text me

from api-plugin-carts.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.