Comments (8)
@MohanNarayana what @karaarda is referring to is that our code is using the version of the schema directly imported from the original definition, not the version that gets extended which is available via the context, therefore even when properly extended schema validation will fail. I think they properly suggest the fix there which is to change the validation in the cart code to use the extended schema via the context. This should be best practice everywhere.
from api-plugin-carts.
All validation is done against simpleSchema. The same schema is available via context. Any change in schema that has to be validated should be added/updated to simpleSchema.js
from api-plugin-carts.
The one I shared in the original post is a valid solution I think.
After trying to find someone to get in touch for a year without luck and finding ourselves re-writing or overriding almost everything, reaction commerce costed us a lot.
from api-plugin-carts.
@karaarda Would you be willing to talk to me about your experiences? https://discord.gg/aqnvYFZc
from api-plugin-carts.
It does not matter for me anymore to be honest.
from api-plugin-carts.
Is that because you are no longer using Open Commerce? Or you found another solution?
from api-plugin-carts.
🎉 This issue has been resolved in version 1.3.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
from api-plugin-carts.
@zenweasel joined the discord server but couldn't find you. feel free to find me in the server and text me
from api-plugin-carts.
Related Issues (9)
- add peerDependency for account plugin
- add peerDependency for address-validation plugin HOT 1
- Build fulfillment groups mechanism makes it impossible to build custom groups HOT 3
- imageURLs missing in CartItem HOT 1
- Fix anonymousCartByCartId query. Make it accept cartId and anonymous access token. HOT 4
- add peerDependency for Tags plugin HOT 1
- ProductConfiguration not provided in anonymousCartByCartId query HOT 2
- the possibility to choose several variants as in the case of a color and size variant HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api-plugin-carts.