GithubHelp home page GithubHelp logo

Comments (4)

aldeed avatar aldeed commented on August 19, 2024

Is that common code? This package API is available only on the server, and in general it's not a good idea to have your rules defined in code that is sent to the client since your rule might be wrong and anyone would be able to see that and exploit it more easily.

from meteor-security.

fuzzybabybunny avatar fuzzybabybunny commented on August 19, 2024

Oh, I see. This obviously makes a lot of sense, but the reason I put this code into common code is because the Discover Meteor book actually has all of their Deny and Allow code in the lib/collections folder, so common code (for the record, I thought this was strange, but chalked it up to them wanting to use latency compensation). I simply followed the same pattern. Perhaps add in the ReadMe that this security package should be defined on the server?

from meteor-security.

aldeed avatar aldeed commented on August 19, 2024

I agree it's confusing, mostly because Meteor documents allow/deny as server-only but yet defines them in common code. For now we'll keep this pkg server-only, but if the Meteor docs ever change to indicate they officially support calling allow/deny on the client, then we can probably do the same. Just because I'm opinionated does not mean this pkg has to be.

In the meantime, I clarified the readme.

cc: @estark37 and @SachaG

from meteor-security.

SachaG avatar SachaG commented on August 19, 2024

I also find it confusing. In fact I think I had just assumed allow and deny ran on the client too…

from meteor-security.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.