send Action.events before sending events on the applied producer? about reactiveswift

[mdiep]

TBH, I'm not sure if there's a reason that one comes before the other. 🤔

I suspect that you'll sometimes want one order and sometimes want the other. So changing this would likely inflict pain on some users.

In this case, your isRegistered property does seem a little weird. Just looking at the events feels funny: it doesn't seem like that should be the source of truth. Presumably registering does something; it seems like the property should based on whatever that thing is.

[pteasima]

Thanks for the answer. You are right that the registration flow here is weird (its still a prototype app, normally we would get back something like a token). However, this is not the first time I have encountered this problem. I generally dont like to do sideEffects in the producer returned from an action, and prefer doing this by binding against the .values or .events.map { //....

My general feeling is that if the producer "wraps" the action logic inside it, then there should be no more work done after the producer sends a terminating event (not even the internal "send the same event on the action's observer" work). However, I agree that its a breaking change which could cause trouble, so Im closing this.