Replace TimeInterval in APIs with DispatchTimeInterval about reactiveswift

[mdiep]

I just added #88 to the 1.0 milestone because #22 was in there. I think those are the last things that we need to resolve.

[ikesyo]

We probably need an extension like this:

extension Date {
    internal func addingDispatchTimeInterval(_ interval: DispatchTimeInterval) -> Date {
        switch interval {
        case let .seconds(s): ...
        case let .milliseconds(ms): ...
        ...
        }
    }
}

[liscio]

We probably need an extension like this:

Should we not instead remove the use of Date entirely in favour of DispatchTime? I never did like using {NS,}Date to represent a point in time…

The usage gets much nicer, too. Compare using Date().addingDispatchTimeInterval(.milliseconds(300)) vs. .now() + .milliseconds(300), for example.

[NachoSoto]

Yup 👍

[liscio]

I've gone ahead and done much of the work already here for a whole-hog replacement of Date and TimeInterval: master...liscio:cl-dispatchwalltime

Unfortunately, it appears that DispatchWallTime (and DispatchTime, but we don't want to base our scheduler on that) is busted in the Swift standard library. I filed a bug (SR-2807) to track the issues I encountered. Specifically, the crash when comparing two DispatchWallTimes is going to block progress.

[liscio]

I've also gone ahead and opened #48 with the approach that was originally proposed, since it's not practical to expect the above issue to get corrected in time for 1.0.

[ashfurrow]

It looks like this was fixed by #48 (good job!). Is the 1.0 milestone up to date? This is the only open issue left in it at the moment.