GithubHelp home page GithubHelp logo

Comments (8)

glennawatson avatar glennawatson commented on April 27, 2024 1

Thanks for the decent bug report. Will have a look this weekend I hope.

from reactiveui.

glennawatson avatar glennawatson commented on April 27, 2024 1

In terms of contributing, happy to help you out with any of the steps.

Here's some tips I would recommend

Get RxUI source code using a git client. Make a fork so you can contribute back. GitHub web UI makes this easy.
Include the rxui csproj's instead of a NuGet reference in your solution to test with
Create a branch
push the code fix to the branch
ideally add a unit test if able with your fix. We don't have MAUI runners at the moment for unit testing so this step may not be possible.
Create a pull request.

Happy to help out with any other information you need.

from reactiveui.

idotta avatar idotta commented on April 27, 2024

Has anyone found the right solution for this problem or should we just use Skip as suggested?

from reactiveui.

glennawatson avatar glennawatson commented on April 27, 2024

Skip is your best bet at the moment. Sorry haven't got to checking into this one yet.

Happy for a community submitted PR for anything like this one.

from reactiveui.

idotta avatar idotta commented on April 27, 2024

Ok, thanks! I'm not sure I could help, since I don't have experience in contributing, but I'll give it a try.

from reactiveui.

idotta avatar idotta commented on April 27, 2024

@glennawatson I think that filtering Navigate to execute only when the NavigationStacks have different sizes solves the problem and makes the call to SyncNavigationStacksAsync unecessary (I left it on my PR, just in case).

from reactiveui.

ChrisPulman avatar ChrisPulman commented on April 27, 2024

I understand this is resolved, I will close it now, if there is still an issue please raise an issue with the new findings. Thank you

from reactiveui.

github-actions avatar github-actions commented on April 27, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from reactiveui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.