ReactiveCollection should be CLS compilant (partial patch attached) about reactiveui

[anaisbetts]

What is the practical benefit to being CLSCompliant (i.e. what scenarios are currently impossible but are now enabled with this?)

If the library is CLS compilant you can be sure that it is usable by all .NET languages such as VB, F# etc (in short being CLS compilant set some constraints on the naming externally accessible (public/protected) functions and variables).

In this specific instance protected members variables starts with underscore which is not possible all .Net compatible languages.

[anaisbetts]

Which languages don't support this? Removing protected member variables that start with underscore is a breaking change.

Regarding which languages don't support leading underscore I have seen some examples earlier but right now I can only come up with C++ where leading underscore is reserved.
"Use of two sequential underscore characters ( __ ) at the
beginning of an identifier, or a single leading underscore
followed by a capital letter, is reserved for C++ implementations
in all scopes."

I would still argue for at least putting CLSCompilant(true) at the assembly level so that other isssues such as names that differ only by case (which won't work with VB) is not introduced.

To preserve backwardscompability you could do a rename on the variables and then create propteries.
One property (which is annotated as depreciated and CLSCompilant(false)) with the old name and another version with a new name such as Changed. By not exposing member variables directly but though properties you also adhere to OO best practices.

Ex:
Old:
protected IObservable<IObservedChange<object, object>> _Changed;
New:

[Obsolete("use Changed instead")]
[CLSCompilant(false)]
protected IObservable<IObservedChange<object, object>> _Changed { get {return _changed;} set {_changed = value;} }
protected IObservable<IObservedChange<object, object>> Changed { get {return _changed;} set {_changed = value;} }
private IObservable<IObservedChange<object, object>> _changed;

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.