GithubHelp home page GithubHelp logo

Comments (3)

vitaly-t avatar vitaly-t commented on August 22, 2024 4

I like this idea!

Perhaps because it is your own idea? 🥲 Perhaps you like all your ideas? 🥲

P.S. I like my comment!

from rxjs.

voliva avatar voliva commented on August 22, 2024 2

@hansschenker sorry I did a 👎 without giving a reason.

The pipe operator is not using TS' variadic arguments and is using many overloads instead because it needs to have some properties that, at least on the previous TS versions, it was impossible to achieve.

You need to have a pipe function that can automatically infer the value of each Operator within the chain, as well as find incompatibilities:

from([1,2,3]).pipe(
  map(v => {
    // TS knows v is a number, so you can run .toFixed() on it
    return v.toFixed();
  }),
  switchMap(v => {
    // TS knows v is a string
    ...
  })
);

There has been multiple attempts at leveraging TS variadic types to simplify that and also allow for a potentially infinite amount of arguments, but so far it has been just not possible to do. Probably the most advanced one was #6671, unfortunately he removed the gist, but it did allow an arbitrary amount of arguments and it would check that every type matches. The problem was that you had to manually fill in all of the type annotations and it would just perform the check, throwing a "is not assignable to never" in case it failed.

Your proposed solution:

// Define a type alias for variadic functions
type PipeFunctions<T> = [(source: Observable<T>) => any, ...Array<UnaryFunction<any, any>>];

is just using any everywhere, so no inference will be done and no type checking will happen whatsoever.

from rxjs.

hansschenker avatar hansschenker commented on August 22, 2024

I like this idea!

from rxjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.