React as PeerDependency about express-react-views

[zpao]

I think that's probably fine. So I guess app.js would look like this?

var React = require('react');
var views = require('express-react-views');
app.engine('jsx', views.createEngine(React, options));

Then we would just need to feature/version check to make sure renderToStaticMarkup exists.

Want to give it a shot?

[thom4parisot]

Yep I will npm link a fork of this module to give and try.

I will push that as a PR if it is successful.

[sophiebits]

Does npm not check the version for you? I don't think you should have to check for renderToStaticMarkup manually.

[zpao]

@spicyj I don't think peerDeps are really properly checked, though I could be wrong. I agree it seems silly... If we get the check for free then yea, we shouldn't do it ourselves.

[ekryski]

Yes, the lack of peerDependency is actually not allowing you to render a component. It returns this error:

Error: Invariant Violation: renderComponentToStaticMarkup(): You must pass a valid ReactComponent.
    at invariant (/usr/local/lib/node_modules/express-react-views/node_modules/react/lib/invariant.js:49:15)
    at Object.renderComponentToStaticMarkup (/usr/local/lib/node_modules/express-react-views/node_modules/react/lib/ReactServerRendering.js:67:44)
    at View.renderFile [as engine] (/usr/local/lib/node_modules/express-react-views/index.js:36:23)

This is because react checks for instanceof ReactDescriptor (seen here), and since your app and express-react-views are using different instances of react it is always false.

This is fixed by setting react as a peer dependency. I have issued PR #4 for this.

[lijunle]

Hello! I debug a long time, and get the same result as @ekryski . (I hope I read this before :( )

@oncletom , please merge RP #4 to resolve this problem.

[zpao]

It got merged. I'll be pushing out 0.5 shortly

[thom4parisot]

\o/