GithubHelp home page GithubHelp logo

Support for React 0.14 about react-modal HOT 5 CLOSED

reactjs avatar reactjs commented on April 30, 2024
Support for React 0.14

from react-modal.

Comments (5)

arasmussen avatar arasmussen commented on April 30, 2024

react-modal also needs to use renderSubtreeIntoContainer instead of render in order for context to work properly. This is the last thing blocking my upgrade to 0.14rc.

from react-modal.

ggarek avatar ggarek commented on April 30, 2024

I tried the PR and it does not work for me. =(

I get these errors in the console:

Uncaught Error: Invariant Violation: addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's `render` method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).

Uncaught Error: Invariant Violation: removeComponentAsRefFrom(...): Only a ReactOwner can have refs. You might be removing a ref to a component that was not created inside a component's `render` method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).

Sadly, did not find a way to fix it yet.

And one more thing, may be it would be wiser to use fbjs instead of exenv.

from react-modal.

conorhastings avatar conorhastings commented on April 30, 2024

@ggarek facebook reccomends against using fbjs

If you are consuming the code here and you are not also a Facebook project, be prepared for a bad time. APIs may appear or disappear and we may not follow semver strictly, though we will do our best to. This library is being published with our use cases in mind and is not necessarily meant to be consumed by the broader public. In order for us to move fast and ship projects like React and Relay, we've made the decision to not support everybody. We probably won't take your feature requests unless they align with our needs. There will be overlap in functionality here and in other open source projects.

from react-modal.

YuriSizov avatar YuriSizov commented on April 30, 2024

So, 0.14 was officially released yesterday. Is there an ETA on when react-modal will be compatible with it?

from react-modal.

mzabriskie avatar mzabriskie commented on April 30, 2024

I believe that #78, and #79 will resolve this issue.

from react-modal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.