GithubHelp home page GithubHelp logo

Comments (11)

roth1002 avatar roth1002 commented on May 1, 2024

👍

from react-modal.

mzabriskie avatar mzabriskie commented on May 1, 2024

Let me look through the issues to see if we can get anything else in the release. I will try and get something out by this afternoon.

from react-modal.

tbaeg avatar tbaeg commented on May 1, 2024

+1 @mzabriskie thanks for all the hard work!

from react-modal.

vonwao avatar vonwao commented on May 1, 2024

@mzabriskie If you haven't done the release yet, may I suggest meteor support?

It looks like it already should be in master branch, there was a merge in #70, but I'm not certain this fixes it completely. See #73 for meteor error.

I'd be happy to test it, as soon as I figure out how to install local npm module dependency in meteor.

from react-modal.

mzabriskie avatar mzabriskie commented on May 1, 2024

Just released 0.6.0, which includes support for [email protected]

from react-modal.

natorojr avatar natorojr commented on May 1, 2024

Sweet! Just confirmed the 0.6.0 release published to npm fixes my broken Webpack build. Testing functionality next.

from react-modal.

alex-kononovich avatar alex-kononovich commented on May 1, 2024

It seems like something went wrong with build process: dist/react-modal.js got 17,874 additions this version (1ff6a02). Looks like whole React got embedded!

from react-modal.

mzabriskie avatar mzabriskie commented on May 1, 2024

Yikes. I bet it's because I'm not setting react-dom as an external. I'll look into it.

from react-modal.

alex-kononovich avatar alex-kononovich commented on May 1, 2024

I've created a pull request that fixes build #87

from react-modal.

mzabriskie avatar mzabriskie commented on May 1, 2024

[email protected] fixes problem with ReactDOM being included in bundle.

from react-modal.

alex-kononovich avatar alex-kononovich commented on May 1, 2024

Thanks, Matt!

from react-modal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.