can't modify immutable index when precompiling in 1.0.0 about react-rails

[juno]

Same issue here.
I investigated that this issue introduced by changes in 8b110af.

[nLight]

Exactly the same issue.

@JakubMal should we roll back these changes? config.after_initialize won't work due to sprockets architecture.

'initialiser' block receives Sprockets::Environment instance as app.assets, that allows to expire_index!
But 'config.after_initialize' receives Sprokets::Index instance, that throws an exception in expire_index! method.

[thmzlt]

Same issue here. Reverting 8b110af fixes it.

[jtmalinowski]

Yeah, I'm not sure what was the reason for this change. Anyway, @johnthethird, whom I can't ref here made a nice fix, and I asked him to PR it separately, because I don't know how much we need to finish server-side rendering. It looks like his busy though, and so if he won't reply in a few days I'll cherry-pick his fix into master, and I'll try to credit him somehow.

EDIT: So I think Tuesday would be a nice day to review and finish this.

[jtmalinowski]

I have tested this using current master and it works for all known cases, let's reopen if we find a case for which this won't work.