Comments (16)
I think it's a rather old issue and PR...Last year some time I believe...I haven't looked at it in a while either. It might be worth just doing a "close and forget" (on the PR) - I'd be ok with that of course. It's your call @bvaughn! I think we all appreciate the effort needed to review these 👍
from reactjs.org.
Hey sorry @bvaughn is this now closed?
Actually never mind, I looked at it wrong, the issue #10897 is closed. Sorry about that
from reactjs.org.
No problem. 😄 Are you interested in helping out with this issue? Lots of work to be done here. Could be cool!
from reactjs.org.
Hey @bvaughn yes I am still kind of new to open source and still learning Flow Types, but yes I would like to help out on this particular issue.
from reactjs.org.
Okay! Great.
This is a pretty big issue, so my advice is- let's do it a couple files at a time. That way it's easier to review and we don't risk conflicting with every other PR.
from reactjs.org.
Sounds good!
from reactjs.org.
I can help as well. Going through a couple of files at a time seems like a good idea.
from reactjs.org.
Okay. I'll mark this issue in-progress.
Communicate here to avoid stepping on each other's toes. 😄
from reactjs.org.
Awesome. I've already opened a PR for it (but forgot to mention the issue number on the commit): #156. Sorry about that. Perhaps if it checks out, then it can be merged so that we keep on top of it and avoid conflicts as much as possible?
I'd like to continue working on it though. So I can continue on it next week if that's ok. I'll work through the src/components
files first.
Do you think it's worth doing the utils as well? Adding flow typechecking there as well?
from reactjs.org.
Do you think it's worth doing the utils as well? Adding flow typechecking there as well?
Yeah 😄
from reactjs.org.
@bvaughn Is this still in progress? I'd love to work on it
from reactjs.org.
Please feel free to contribute anywhere you see missing types or types that could be improved, @wuweiweiwu. Probably worth checking through open pull requests first to make sure something hasn't already been done though! We usually let first-in win.
from reactjs.org.
@bvaughn Sounds good!
from reactjs.org.
Hey @bvaughn, I'd like to work on it too, is this still in progress?
from reactjs.org.
I don't know. Looks like there's another open PR (#449) that got dropped because I just haven't had time to review this repo lately :( SOrry
from reactjs.org.
No problem :), just looking for an issue to get started here.
from reactjs.org.
Related Issues (20)
- [Bug]: The "react.dev" survey asks about "beta.reactjs.org" documentation HOT 1
- Inavlid hook call HOT 3
- [Bug]: all new sandboxes (with ShowRenderedHTML) break HOT 2
- ReactDOM.render render to body without warning HOT 1
- [Typo]: `crossOrigin` and `as` values content HOT 1
- Broken link
- Left-Scroll-Bar[Bug]: HOT 3
- [Typo]: `<style>` syntax looks wrong HOT 1
- [Bug]: Challenges section not connecting to sandbox HOT 3
- [Bug]: Invalid Hook call HOT 1
- .
- [Suggestion]: Add a search page (not just a modal) HOT 1
- [Mistake]: One of the examples in the docs is performing side effect in render? HOT 2
- [Bug]: Can not access the react.dev website HOT 11
- [Bug]: Issue with Sandpacks HOT 7
- Add language switcher to the design in react.dev
- [Suggestion]: Add example for retry with the `use` hook and an error boundary
- [Suggestion]: How to use local language search on a translation website
- [Suggestion]: Clarification on react.cache Usage in Server Requests
- [Typo]: Possible incorrect info HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactjs.org.