Comments (3)
Hey @staabm, thanks for the input on this, seems like a reasonable change 👍
If this works as well as you described it above, than I agree that this is a great addition to the project. Will have a look at this when time allows it, but until then we're more than happy about contributions for this. If someone has interest in opening a PR, it's important for us is that the pull request should not only focus on the implementation side of things, but also make sure that any new additions are also covered by our test suite (unit tests) to confirm the suggested changes work as expected.
Additionally, I don't think this is a bug ticket as nothing is currently broken; I think this is more of a feature suggestion. We recommend opening bug tickets only when you can provide evidence of something being broken, just as a friendly reminder for future tickets :)
from child-process.
Just a random thought, but if it's faster, why not internally change it to an array and always have that performance gain?
from child-process.
passing the arg as array has a few more implications. escaping of the command is done at php-src level and no longer in userland.
since the command is no longer run in a shell with array-notation it might depend also on the command whether we can apply array-style arg.
e.g. stderr->stdout redirection needs to be done differently via pipespec
it might make sense to look into the symfony process component for inspiration
from child-process.
Related Issues (20)
- Don't replace generated command from \ to \\ HOT 2
- Next steps for ChildProcess with ReactPHP v3
- STDIO streams should be readable or writable, but not duplex HOT 1
- Roadmap to v1.0.0 HOT 5
- Update stream dependency to 0.7 HOT 1
- Segmentation Fault (core dumped) HOT 19
- Spawn child process and creatie server in it HOT 1
- Persistent SSH Child Process HOT 6
- [FYI] Child processes inherit open file handles from parent HOT 10
- What is the correct way to obtain data from a subprocess HOT 1
- Improper detection of sigchld compile flag HOT 4
- PHPUnit Code Coverage for runned process HOT 1
- Clean up API HOT 3
- Consider adding specific libuv adapter HOT 2
- process terminate not working as expected HOT 1
- Trying to access array offset on value of type null HOT 4
- is it possible to debug a child process? HOT 2
- Fatal error when phpinfo is disabled HOT 4
- Callback as child processes HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from child-process.