Extend ConnectionInterface with ports / target address. about socket

[SamMousa]

@clue As far as I can tell all Layer 4 protocols have a source and target port. How about adding a OsiLayer4ConnectionInterface for those? That would be a relatively simple extension and OSI layers are pretty well defined.

[clue]

C_a.remoteAddress = C_b.localAddress 
and 
C_a.localAddress = C_b.remoteAddress

I think this makes sense 👍 Though I'm not sure what you're suggesting we need to do? :)

When multiple connections are managed, both inbound and outbound, we need to "know" where the connection came from to decide which party we are (local or remote).

I'm not sure I follow, can you elaborate on this? You usually hold a reference to an instance representing the connection, so how exactly can these be mixed up?

How about adding a OsiLayer4ConnectionInterface […]

Care to elaborate on this? What's the motivation for this interface? What does this interface do that the ConnectionInterface is not capable of?

[SamMousa]

I'd like to have a getSourceAddress and getTargetAddress although when thinking about it more, for unix sockets it could be argued that there is no real source address...

I'm not sure I follow, can you elaborate on this? You usually hold a reference to an instance representing the connection, so how exactly can these be mixed up?

I guess it depends on if you use the connection instance passed in the callback or the one you stored upon connection initiation.

Care to elaborate on this? What's the motivation for this interface? What does this interface do that the ConnectionInterface is not capable of?

It could expose things like the port which are part of the OSI 4 layer (afaik).

[clue]

I'm not sure I follow, can you elaborate on this? You usually hold a reference to an instance representing the connection, so how exactly can these be mixed up?

I guess it depends on if you use the connection instance passed in the callback or the one you stored upon connection initiation.

I'm still not sure I follow. Incoming and outgoing connections use different classes, as they're from different components. Using instanceof is much more reliable than checking the addresses (e.g. think of connections to localhost).

It could expose things like the port which are part of the OSI 4 layer (afaik).

You've got me confused, are we talking about #26 here? :-) If so, let's please move the discussion into a single ticket.

[SamMousa]

Ok.