Comments (4)
ajainarayanan
commented on May 5, 2024
2
Exactly. Thanks for the quick response. I am about to create a PR for it. Let me know if I miss something.
from reactstrap.
ajainarayanan
commented on May 5, 2024
1
Awesome! Thank you @eddywashere that was super quick 😃
from reactstrap.
eddywashere
commented on May 5, 2024
Nice catch. It looks like Modal is missing the className pass through that most of the other components have. I'm assuming you meant to add className="my-custom-modal" to Modal and not Button, right?
Also, attach to body was a safe default I went with. There probably should be an option to not append to body. Dropdowns have it. Might be worth doing it for popovers and tooltips as well.
from reactstrap.
eddywashere
commented on May 5, 2024
released in 2.6.1. Thanks again @ajainarayanan!
from reactstrap.
Related Issues (20)
- ERROR: "Class extends value undefined is not a constructor or null" after running Next.js 13 with app dir HOT 9
- Dropdown appered error useState
- Offcanvas example code not working HOT 1
- Dropdown component throws error if used with inNavbar property HOT 4
- DropdownItem looses menuitem role when disabled HOT 1
- Enhancement Request - ModalTitle component
- Tooltip arrows are not visible with Bootstrap 5.3.0 HOT 1
- [deps] Checking for breaking changes in Dependabot's PRs
- Problem to centralize CarouselCaption
- Shift+Tab Model with ShadowRoot
- Carousel: switching interval to false does not deactivate autoplay directly
- Padding issue when closing a modal and opening another at the same time
- FormGroup combined with InputGroup doesn't render properly due to mis-placed class name 'mb-3' HOT 1
- Preventing scroll is not working for nested Offcanvas
- Due to the type definition, UncontrolledAccordion cannot be used without toggle HOT 1
- ReactStrap Navbar is not printed to default pdf printer pf browsers
- Dropdown not working witn Reactstrap v8 and Bootstrap v4 HOT 1
- Use useId() hook in Popover
- It won't accept floating numbers when I add the minimum and maximum number limits. HOT 1
- How do buttons get form data outside the form and go to validation？ HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactstrap.