GithubHelp home page GithubHelp logo

Comments (4)

mickael-menu avatar mickael-menu commented on July 17, 2024

Please next time follow the bug report issue template, as it helps make sure we have all the infos necessary to reproduce an issue.

from r2-testapp-kotlin.

stevenzeck avatar stevenzeck commented on July 17, 2024

Yeah for whatever reason the property setProperty("--RS__advancedSettings", "readium-advanced-on"); needs to be set in the root style before that starts to work. Not sure the best place to fix it to be honest.

from r2-testapp-kotlin.

mickael-menu avatar mickael-menu commented on July 17, 2024

Changing the text alignment requires to have the publisher's defaults to OFF (readium-advanced-on).

So the correct behavior should be to automatically switch off the publisher's defaults when changing any "advanced" setting, and apply the CSS together.

See on Swift: https://github.com/readium/r2-testapp-swift/blob/b2db3fd83d14064eedf781074cfd2cf56bfddaa1/r2-testapp-swift/Reader/EPUB/User%20Settings/AdvancedSettingsViewController.swift#L138-L150

from r2-testapp-kotlin.

ajay9889 avatar ajay9889 commented on July 17, 2024

It is fixed. thanks

from r2-testapp-kotlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.