GithubHelp home page GithubHelp logo

Comments (7)

danielweck avatar danielweck commented on May 13, 2024

See @dmitrym0 's work:

https://github.com/dmitrym0/readium-shared-js/commits/develop
(Note all of the "Auto version update" commits)

dmitrym0/webhook-deployer@09e5edc#commitcomment-6981345

from readium-js-viewer.

danielweck avatar danielweck commented on May 13, 2024

Task: move to dedicated feature branch
https://github.com/readium/readium-js-viewer/blob/develop/update-version.sh
https://github.com/readium/readium-js-viewer/blob/develop/readium-module.json
https://github.com/readium/readium-js-viewer/blob/develop/epubReadingSystem.json
etc.

from readium-js-viewer.

danielweck avatar danielweck commented on May 13, 2024

Moved to feature branch:

https://github.com/readium/readium-js-viewer/tree/feature/version

from readium-js-viewer.

danielweck avatar danielweck commented on May 13, 2024

See also submodules (only additions "readium-module.json" and "update-version.sh"):
https://github.com/readium/readium-js/tree/feature/version
https://github.com/readium/readium-shared-js/tree/feature/version

from readium-js-viewer.

danielweck avatar danielweck commented on May 13, 2024

Note that the grunt shell invoke is asynchronous, so unlike git-describe it doesn't actually work properly right now.
WIP!
https://github.com/readium/readium-js-viewer/blob/feature/version/grunt/epubReadingSystem_processModules.js#L37

from readium-js-viewer.

danielweck avatar danielweck commented on May 13, 2024

@ryanackley thank you very much, this looks great!

I added a separate issue for v1+ (populate epubReadingSystem with detailed version info, similar to my original feature branch):
readium/readium-shared-js#104

from readium-js-viewer.

danielweck avatar danielweck commented on May 13, 2024

@ryanackley here is a follow-up to this, now populating the navigator.epubReadingSystem object: #222

The aforementioned Pull Request includes a new EPUB (in epub_library.json), to display/dump the augmented navigator.epubReadingSystem object (which now contains an additional "readium" field).

Note: this is a simpler design compared to my original "version" feature branch (linked a few comments above), as this is not using a generic hierarchical data structure to describe submodule dependencies (the 3 repository references are hard-coded, piggy-backing on the existing "versioning" code that looks at readium-js-viewer, readium-js, and readium-shared-js). Furthermore, there is no build-time "git-describe" to automatically extract the nearest tag/release name (if needed, this can be obtained "after the fact" from the provided git commit SHA using the command line 'git name-rev --tags --name-only SHA').

I'd appreciate your feedback, thanks!

from readium-js-viewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.