GithubHelp home page GithubHelp logo

Comments (13)

dmitrym0 avatar dmitrym0 commented on July 20, 2024

hey @sajjadrad, did you select any text? Were there any errors in the console?

from sdklauncher-ios.

sajjadrad avatar sajjadrad commented on July 20, 2024

yeah,I draged on screen and after selecting text I clicked on custom highlight button,but nothing happens.
Also there is no message on console.The log value is null too.
Thanks

from sdklauncher-ios.

dmitrym0 avatar dmitrym0 commented on July 20, 2024

Did you look at the xcode console or javascript console?

Did you set the annotations css url (see https://github.com/readium/readium-js-viewer/blob/develop/lib/EpubReader.js#L305 and line 318 further down).

from sdklauncher-ios.

sajjadrad avatar sajjadrad commented on July 20, 2024

I looked up for error in xcode console and javascript console (by safari developer).
There is no submodule with name readium-js-viewer in SDKLauncher-iOS.Is that required?Where?

from sdklauncher-ios.

dmitrym0 avatar dmitrym0 commented on July 20, 2024

Where is the Readium instantiated in the SDK Launcher? It needs to be passed an options hash that specifies where the annotations css is.

from sdklauncher-ios.

sajjadrad avatar sajjadrad commented on July 20, 2024

Do you means readium-sdk? Like develop branch it lives in root of SDK Launcher project.in resource folder I have readium-shared-js folder for js reader.also I searched for annotations css,I cant find that.

from sdklauncher-ios.

sajjadrad avatar sajjadrad commented on July 20, 2024

As I understand the readium is highlighting but there is no css style file,so It wont show the yellow highlight.Is it true?

from sdklauncher-ios.

dmitrym0 avatar dmitrym0 commented on July 20, 2024

Looks like the CSS for highlights is not specified. The second parameter into Readium initializer needs to include hash which points to the css file. Right now, when you generate a highlight, it's not visible because CSS is not specified.

from sdklauncher-ios.

danielweck avatar danielweck commented on July 20, 2024

I actually just recently fixed the "online cloud reader" configuration, which was causing huge page load delays because of the annotation.css HTTP 404:

readium/readium-js-viewer@a9fe543

from sdklauncher-ios.

dmitrym0 avatar dmitrym0 commented on July 20, 2024

Thanks Daniel.. I remember leaving it in a different state, where the CSS wasn't specified..

from sdklauncher-ios.

NinhNT avatar NinhNT commented on July 20, 2024

Hi all, i have the same issue and i can't see css file anywhere. Please help me find the way to fix it.Thanks!

from sdklauncher-ios.

danielweck avatar danielweck commented on July 20, 2024

Hi, I have fixed this in the native OS X launcher app:

readium/SDKLauncher-OSX#20

Will work on iOS shortly.

from sdklauncher-ios.

danielweck avatar danielweck commented on July 20, 2024

Fixed in Pull Requests:
#32
readium/readium-sdk#102
(HTML injection framework now pushes annotations.css, MathJax.js, and navigator.epubReadingSystem)

from sdklauncher-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.