GithubHelp home page GithubHelp logo

Add support for Subtitles about swift-toolkit HOT 5 CLOSED

readium avatar readium commented on August 15, 2024
Add support for Subtitles

from swift-toolkit.

Comments (5)

aferditamuriqi avatar aferditamuriqi commented on August 15, 2024

@iaomw is this related to the subtitle work you already did? can we close this issue? or is this something different?

from swift-toolkit.

iaomw avatar iaomw commented on August 15, 2024

Hi, I could say this one is solved. But the situation is more complex. It could have more than one subtitle. Maybe, it's necessary to make a bigger change on the data structure. So it could cover all the case with one type. @aferditamuriqi

For discussion: readium/r2-streamer-swift#43

from swift-toolkit.

llemeurfr avatar llemeurfr commented on August 15, 2024

Let's have the opinion of our bookseller friend @HadrienGardeur.
Should we handle multiple-subtitles? what about alternate subtitles in different languages?

from swift-toolkit.

HadrienGardeur avatar HadrienGardeur commented on August 15, 2024

A single subtitle is more than enough, I doubt that there are a lot of publications that even have a single subtitle right now.

from swift-toolkit.

llemeurfr avatar llemeurfr commented on August 15, 2024

The current code extracts the first subtitle found in the metadata, which is fine for our reference bookseller. Therefore we can close this issue.

from swift-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.