GithubHelp home page GithubHelp logo

Comments (6)

JayPanoz avatar JayPanoz commented on July 17, 2024

Hmmm, looks like an overlapping issue because the line-height is solid there – that’s weird because we give more room to CJK and the default line-height is 20% bigger than for latin scripts.

As for the wave I have difficulties defining whether this is text-emphasis-style with a custom string, text-underline-style: wavy and or a background-image – which is a popular technique for such things.

from swift-toolkit.

JayPanoz avatar JayPanoz commented on July 17, 2024

On a related note, I can also see missing characters in both screenshots (they happen to be the same one):

capture d ecran 2018-08-10 a 12 11 27

capture d ecran 2018-08-10 a 12 11 39

from swift-toolkit.

iaomw avatar iaomw commented on July 17, 2024

https://drive.google.com/file/d/1CSZXEscGXkdNharMjOknYc82CJEXyvZ1/view?usp=sharing
Testing sample

from swift-toolkit.

JayPanoz avatar JayPanoz commented on July 17, 2024

OK so it’s a background-image

span.kindle-cn-specialtext-double{
	 background-image: url(../Images/image00788.gif);
	 background-repeat: repeat-y;
	 background-size:1em 1em;
	 background-position: 0% 0%;
	 padding-left: 0.15em;
	 margin-bottom: 0em ;
}

And here’s the GIF:

wavy underline

What’s weird is that line-height in r2 looks like normal while it should be the result of https://github.com/readium/readium-css/blob/master/css/src/modules/ReadiumCSS-base.css#L38 with a compensation of 1.167 (https://github.com/readium/readium-css/blob/master/css/src/modules/ReadiumCSS-base.css#L197)

What’s strange is that this is the line-height I get, which is very different from the one in the first screenshot:

capture d ecran 2018-09-18 a 11 33 59

A couple of extra notes:

  1. the file is ePub 2 (not EPUB3)
  2. it is specifically authored for Kindle (all class names start with kindle)
  3. It is using <meta content="vertical-rl" name="primary-writing-mode" /> (cf. compat doc) in addition to page-progression-direction.

I’m assuming this wasn’t a Kindle Mobi file converted back to EPUB as it lacks some meta artifacts you’ll typically find in such retro-conversions… but maybe I’m wrong?

from swift-toolkit.

JayPanoz avatar JayPanoz commented on July 17, 2024

Also extra notes related to readium/architecture#70

cc @HadrienGardeur and @llemeurfr

If this isn’t retroconverted, that could be either an exception or the rule, in which latter case… the number of such files could be massive on markets we are not necessarily familiar with.

from swift-toolkit.

mickael-menu avatar mickael-menu commented on July 17, 2024

From what I gather it's nothing we can fix in the Swift projects directly. Feel free to reopen the issue with more details on how to fix this in Swift if I misunderstood.

from swift-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.