Comments (3)
mickael-menu-mantano
commented on August 15, 2024
Note for anyone tackling this issue: Link.href can be templated and thus should stay as a String, because the conversion with URL loses information.
from swift-toolkit.
aferditamuriqi
commented on August 15, 2024
@mmenu-mantano can we close this issue then?
from swift-toolkit.
mickael-menu-mantano
commented on August 15, 2024
No it's actually not done yet, I commented this to make sure that the person tackling this issue wouldn't convert the Link.href to an URL, as it would break templated Links.
By the way, I think this issue is quite important because I already got problems (in another app) using paths for String directly, because of APFS's Unicode normalization. This occurs when using for example accentuated characters in filenames. Using URL is usually safer in this case.
https://eclecticlight.co/2017/04/06/apfs-is-currently-unusable-with-most-non-english-languages/
from swift-toolkit.
Related Issues (20)
- Navigator places locator with anchor in the middle of the screen in scroll mode
- Impossible to open resource with linear=no HOT 1
- Error when trying to open EPUB with Fixed Layout [iOS] HOT 7
- Xcode 15 and iOS 17 - Stored properties cannot be marked unavailable with '@available' HOT 3
- Building Latest TestApp works only on Simulator HOT 1
- [Feature support] : Underline and ability to add notes HOT 3
- Wrong position after rotation HOT 5
- Make `_AudioNavigator` periodic time observer interval configurable? HOT 3
- HTML injection fails if the resource contains a commented-out `<html>` tag HOT 1
- Test App fails to open epub files from Files HOT 1
- Decorations take a long time to apply on large html files HOT 2
- Decorations are incorrectly applied to paragraphs that start with a special character HOT 4
- Current Selection Locator has incorrect data describing the text HOT 2
- "Highlight" editing action doing nothing in the PDF Navigator
- When in landscape mode (width > height) the EPubNavigationViewController always starts on the first page in the chapter
- Missing search results in the Test App HOT 1
- Extracting `t` fragment from `Locator` HOT 1
- Larger Text Display Zoom on iPhone: Navigation bar pushes text HOT 3
- Pinning the font size (for <p>, <li>, <div>, etc) HOT 1
- Logger doesn't log above min severity level
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swift-toolkit.