GithubHelp home page GithubHelp logo

Comments (6)

oppianmatt avatar oppianmatt commented on July 19, 2024 2

Where did you see docker-compose is removing links?

docker is removing legacy container links https://docs.docker.com/engine/userguide/networking/default_network/dockerlinks/

I believe links are still there, just now with the network. On the docker-compose links reference page:

Links also express dependency between services in the same way as depends_on, so they determine the order of service startup.

Note: If you define both links and networks, services with links between them must share at least one network in common in order to communicate.

So links is still used, and used to determine startup order. So if web links to postgres then running web will also start postgres first.

# built the containers if needed
$ docker-compose -f production.yml build
# migrate if needed, will automatically start postgres, run this if pulling new migrations down
$ docker-compose -f production.yml run web python -u manage.py migrate
# start up anything that hasn't already started
$ docker-compose -f production.yml up -d

Note if postgres is restart always, it will be started anyway.

For windows/mac users the migrate command needs to be:

# windows/mac users have to run in detach mode
$ docker-compose -f production.yml run -d web python -u manage.py migrate --noinput
# but you can still monitor progress
$ docker-compose logs <containername>

from dockerizing-django.

mjhea0 avatar mjhea0 commented on July 19, 2024

You would at least need to get Postgres up before running the migrations if you handle it that way.

from dockerizing-django.

oppianmatt avatar oppianmatt commented on July 19, 2024

With the links in compose it will start the postgres container when you run the web container to do the migrate.

If you don't do the migrate first AND there are new migrations it might error on startup until you run migrate. For example if you have pulled new migrations down from in a team.

from dockerizing-django.

mjhea0 avatar mjhea0 commented on July 19, 2024

Your suggestion is to remove the links and then run the commands in this order? @oppianmatt

$ docker-compose -f production.yml build
$ docker-compose -f production.yml run web python -u manage.py migrate
$ docker-compose -f production.yml up -d

from dockerizing-django.

oppianmatt avatar oppianmatt commented on July 19, 2024

no keep the links but do the run migrate first. It will start up postgres as needed and apply any migrations that might be in the source and not in the db.

from dockerizing-django.

mjhea0 avatar mjhea0 commented on July 19, 2024

I believe Docker is removing links altogether in the next release. May be worth removing them now. Also the DB would have to be up, so the commands would need to be:

$ docker-compose -f production.yml build
$ docker-compose -f production.yml up postgres -d
$ docker-compose -f production.yml run web python -u manage.py migrate
$ docker-compose -f production.yml up -d

from dockerizing-django.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.