GithubHelp home page GithubHelp logo

Comments (5)

jxnblk avatar jxnblk commented on May 6, 2024

Thanks! I'm looking into a better way to configure the more complex components like this one, so stay tuned.

from rebass.

primozs avatar primozs commented on May 6, 2024

What about introducing new sx prop:

  let sx = {
    root: {
      display: 'inline-block'
    },
    value: {
      fontSize: fontSizes[0],
      letterSpace: '-.125em',
      fontWeight: bold,
      lineHeight: 1,
      marginTop: topLabel ? scale[1] / 2 : null,
      marginBottom: topLabel ? null : scale[1] / 2
    },
    unit: {
      fontSize: fontSizes[3]
    },
    label: {
      fontSize: fontSizes[6],
      fontWeight: bold,
      lineHeight: 1
    }
  };

  sx = {
    ...sx,
    ...props.sx
  };

from rebass.

jxnblk avatar jxnblk commented on May 6, 2024

I think I'd rather just leverage the default style prop if possible. Is there any reason nesting objects for sub elements in style wouldn't work?

E.g.

style = {
  color: 'tomato', // passed to the root element
  Stat_value: { // passed to sub elements by name
    color: 'green'
  }
}

from rebass.

primozs avatar primozs commented on May 6, 2024

This would be good... This is not implemented right?

from rebass.

jxnblk avatar jxnblk commented on May 6, 2024

Not currently, no

from rebass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.