GithubHelp home page GithubHelp logo

Comments (6)

gigabo avatar gigabo commented on May 2, 2024

Thanks @kcjonson. It would be nice to get rid of the extra level of nesting. I'll see if I can make that work.

from react-server.

gigabo avatar gigabo commented on May 2, 2024

So... I've tried:

  • Cloning each root element with a data-triton-root-id prop. Doesn't work, prop not propagated down to actual dom element.
  • Walking down through children to find first actual dom element to clone with a data-triton-root-id prop. Doesn't work, some elements don't have the dom node in their children until render time, which is too late.
  • Doing string-replacement to add a data-triton-root-id attribute to the HTML on the way out. Doesn't work, React freaks out and blows away the DOM branch.
  • Doing string-replacement, and then calling removeAtribute(...) before rendering into the root. Doesn't work, React still somehow freaks out and blows away the DOM branch.

Not sure we're going to be able to eliminate the wrapping div.

What about being able to set properties on it? Like className, style, id, etc? Would that get you what you need for layout purposes?

from react-server.

egid avatar egid commented on May 2, 2024

From my perspective, yes - allowing us to add attributes to root elements solves most of the issue. It still winds up being messier than needed, and I'm sure has some cases where it's not a full solution, but it solves the immediate problem.

from react-server.

gigabo avatar gigabo commented on May 2, 2024

Okay, cool. That should actually be pretty easy and fairly clean.

I'll just add support for those props to <RootElement />.

from react-server.

kcjonson avatar kcjonson commented on May 2, 2024

Yea, that solves the technical problem. Still feels a bit dirty to have all the extra nodes lying around, but if its going to open a can of worms we can move on.

from react-server.

gigabo avatar gigabo commented on May 2, 2024

Available in v0.0.9.

from react-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.