Comments (6)
Thanks @kcjonson. It would be nice to get rid of the extra level of nesting. I'll see if I can make that work.
from react-server.
So... I've tried:
- Cloning each root element with a
data-triton-root-id
prop. Doesn't work, prop not propagated down to actual dom element. - Walking down through children to find first actual dom element to clone with a
data-triton-root-id
prop. Doesn't work, some elements don't have the dom node in their children until render time, which is too late. - Doing string-replacement to add a
data-triton-root-id
attribute to the HTML on the way out. Doesn't work, React freaks out and blows away the DOM branch. - Doing string-replacement, and then calling
removeAtribute(...)
before rendering into the root. Doesn't work, React still somehow freaks out and blows away the DOM branch.
Not sure we're going to be able to eliminate the wrapping div.
What about being able to set properties on it? Like className
, style
, id
, etc? Would that get you what you need for layout purposes?
from react-server.
From my perspective, yes - allowing us to add attributes to root elements solves most of the issue. It still winds up being messier than needed, and I'm sure has some cases where it's not a full solution, but it solves the immediate problem.
from react-server.
Okay, cool. That should actually be pretty easy and fairly clean.
I'll just add support for those props to <RootElement />
.
from react-server.
Yea, that solves the technical problem. Still feels a bit dirty to have all the extra nodes lying around, but if its going to open a can of worms we can move on.
from react-server.
Available in v0.0.9
.
from react-server.
Related Issues (20)
- Upgrade to Webpack 4 + Babel 7 HOT 1
- compileOnStartup feature left out
- finishRoute() never fired when all elementPromises don't resolve
- Question:how does react-server achieve stream pre-rendered HTML
- Hi
- TODO IE8-9 Detection
- TODO if OSX && key is.Meta?
- ReactServerAgent only suited for use in pages?
- Build Server & Client Libraries with esnext and ES Modules HOT 4
- Page request fired twice when using bundleData
- Make react-loadable in the react-server HOT 1
- Hash fragment removed from URL in browser in version 0.8.1, how can I save it in URL for scroll to section?
- https://react-server.io/ returning 503 HOT 2
- TODO: handle compilation errors with a --reportwarnings flag
- TODO: create a READEME.md for flab
- TODO: use config for env var in repo.js
- TODO: support dash-separated options in config
- Improve Lerna + NPM Integration
- NPM Audit
- Do Lint Better
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-server.