Comments (3)
One more useful behavior could be to move the navigation toggle hamburger in Tab order to be after the top bar, right before the navigation links, and skip them when hidden. Then when not navigating you can keep it closed and only see a single Tab step, and press Space/Enter to open it when needed.
Another idea could be to make left navigation always reachable by Tab, and always shown when so focused — then it may be better to move the whole navigation before top bar, and add some way to skip navigation / skip to content.
We have opted to use the default PF behavior. I would suggest creating an issue in their repository to change the page layout behavior.
We will remove the focusing of the nav items if the nav hidden.
from insights-chrome.
@cben thanks for reporting the issue. I will go over it probably tomorrow.
from insights-chrome.
Having the hamburger the first thing is a pattern defined by Patternfly. We don't have a "skip to content" so this should be the first thing.
However, when the hamburger is closed, we should not be able tab through any of those items, so yes that is a bug.
from insights-chrome.
Related Issues (20)
- Remediaitons: Error when loading component HOT 1
- Login page does not load on ci-beta HOT 3
- Minified react error at /beta/security/insights HOT 1
- Product Docs, infinite load of chrome and component HOT 4
- AsyncComponent usage example
- Page drawer implementation enhancement HOT 3
- A11y errors caused by incorrect landmark elements in page structure HOT 1
- Help and Settings menus do not have discernible text for screen readers
- getToken() returns empty tokens HOT 8
- The chrome.auth.getToken() should wait for the jwt initPromise like the getUser() HOT 10
- Page breaks when clicking manifests link on side nav after manifests page has loaded HOT 2
- Question: what's the suggested strategy to deal with @patternfly versions? HOT 4
- Create test script for build vs regular one HOT 1
- getOfflineToken fails if there is a URL param HOT 12
- Analytics: isProd check includes local dev env URL HOT 6
- build fails on Fedora 36 with ERR_OSSL_EVP_UNSUPPORTED HOT 2
- setPageMetadata metadata on first page load HOT 5
- Kiota headers get garbled HOT 2
- RTK Query mutation/POST request headers are missing HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from insights-chrome.