Comments (1)
Glutexo
commented on August 28, 2024
Not only it’s not the DB object’s responsibility to export JSON or be built from JSON. I’d say that even the other methods like update, update_display_name etc. don’t belong there. They do the application logic and not anything related to the ORM.
Moreover the from_json, to_json and to_system_profile_json methods don’t even do anything related to JSON. They just (de)serialize the data to/from a dictionary. The fact that these dictionaries relate to JSON in other parts of the application is not relevant to the model.
from insights-host-inventory.
Related Issues (20)
- Prefix environment variables HOT 1
- Move Kafka configuration to the config object
- Improve Kafka consumer toggle
- Remove unittest.mock from API tests HOT 1
- Decouple DB model from logic HOT 2
- Extract host (de)serialization HOT 1
- Missing License file
- Fix all Flake8 rules
- App initialization utilizes import and decorator side effects
- namepsace file typo
- Lock dependencies to specific versions HOT 2
- Kafka client doesn’t resolve localhost on a Mac
- DRY host-related schemas
- Use Marshmallow to serialize Host
- Check ObjectDeletedError catching on delete HOT 3
- KafkaProducer doesn’t flush
- Double encoding of egress events HOT 1
- need to use sa.DateTime(timezone=True) so time zone is accounted for when storing datetime in the db. HOT 1
- Add tag count to `/hosts` endpoint HOT 1
- Extend system_profile filter to support the cloud_provider field.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from insights-host-inventory.