GithubHelp home page GithubHelp logo

Comments (5)

Glutexo avatar Glutexo commented on August 28, 2024

Reproduced. Details: The bug is caused by passing the string directly to the SQL query. PostgreSQL complains about querying a UUID field by an invalid value:

sqlalchemy.exc.DataError: (psycopg2.DataError) invalid input syntax for uuid: "bbq"
LINE 3: WHERE hosts.account = 'abc123' AND hosts.id IN ('bbq')

I see two problems here:

  • The UUID parameters are not validated.
  • The SQL exceptions are not caught. This is actually correct: if an invalid query is built, it is an internal server error.

The validation can be hot-fixed by checking the ID in the view function. But a correct approach would be to define a custom validator for Connexion: https://connexion.readthedocs.io/en/latest/request.html?highlight=data#custom-validators

from insights-host-inventory.

Glutexo avatar Glutexo commented on August 28, 2024

Pinning as this looks like a bug bug to me.

from insights-host-inventory.

Glutexo avatar Glutexo commented on August 28, 2024

This bug is still present. Created a new ticket for this.
https://projects.engineering.redhat.com/browse/RHCLOUD-350

from insights-host-inventory.

Glutexo avatar Glutexo commented on August 28, 2024

This is fixed. To some extent probably by #160.

I checked all the cases when the UUID is passed in the request and all are caught with 400 Bad Request.

from insights-host-inventory.

Glutexo avatar Glutexo commented on August 28, 2024

Created some pull requests to cover all the request UUID validation cases by tests. See #265.

from insights-host-inventory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.