Comments (7)
I have updated my branch based on your suggestions, with one change. It seems like having predefined methods as a config option would be akward, but I see the value in getting new redis methods "for free" so I went ahead and added method_missing back in. Now methods known about before-hand will be already defined and new methods will be passed to method missing. This seems like a win-win to me.
I followed your other suggestions and moved the list of method names to a config file and switched to class_eval for better performance. The changes are pushed to my branch - let me know if you have any other feedback or if there is more I can/should do to help get this patch accepted.
from redis-rb.
This continues to cause issues in our Rails environment where, as an example, get is defined on some base object. As a result redis.get("key") resolves to that version of get, and returns an error from rails my controller needs some love.
from redis-rb.
This issue will be fixed when this branch is merged to master: http://github.com/ezmobius/redis-rb/tree/new_protocol. In the meantime, can you test with that branch and see if it works for you?
from redis-rb.
We made a temporary fix on 004e7a7. Will try to get a new point release soon with this and other fixes. We only added get
because delete
is deprecated in favor of the native del
.
from redis-rb.
Master no longer uses method_missing
, although it's there in order to support not-yet-declared commands.
from redis-rb.
Awesome sauce, no more redis.call_command ["get", key] we'll check it out this week.
from redis-rb.
get
should be working as well on 1.0.5 and 1.0.6.
from redis-rb.
Related Issues (20)
- redis-client requires Redis 6+ with HELLO command available HOT 2
- SORT_RO support HOT 1
- `ERR value is not an integer or out of range` after redis.ping HOT 4
- LMPOP not working HOT 5
- Unable to load application: TypeError: superclass mismatch for class Cluster HOT 7
- status
- Sentinel TLS: Sentinel TLS not supported HOT 5
- Configure Rails redis_cache_store with redis 5 HOT 1
- Unable to create redis cluster HOT 1
- Add support for redis Time Series module HOT 1
- OpenSSL::SSL::SSLError: SSL_write: unsupported method HOT 1
- Max number clients reached using subscribe_with_timeout HOT 2
- [Doc] Improve documentation about acceptable regular expressions pattern HOT 4
- Behavior of `pipelined { multi }` changed HOT 1
- 5.x seems to break IPv6 URL parsing HOT 1
- Redis::Cluster attempting Redis connection during asset precompilation HOT 5
- initialize': no implicit conversion of String into Integer (TypeError) HOT 1
- `:blpop` returns an exception when using sentinels HOT 3
- Proper documentation on how to setup rails to connect to a redis cluster for session management HOT 14
- redis-clustering: NoMethodError: undefined method `node_keys' for nil:NilClass HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redis-rb.