GithubHelp home page GithubHelp logo

Comments (7)

dougcole avatar dougcole commented on July 25, 2024

I have updated my branch based on your suggestions, with one change. It seems like having predefined methods as a config option would be akward, but I see the value in getting new redis methods "for free" so I went ahead and added method_missing back in. Now methods known about before-hand will be already defined and new methods will be passed to method missing. This seems like a win-win to me.

I followed your other suggestions and moved the list of method names to a config file and switched to class_eval for better performance. The changes are pushed to my branch - let me know if you have any other feedback or if there is more I can/should do to help get this patch accepted.

from redis-rb.

aconbere avatar aconbere commented on July 25, 2024

This continues to cause issues in our Rails environment where, as an example, get is defined on some base object. As a result redis.get("key") resolves to that version of get, and returns an error from rails my controller needs some love.

from redis-rb.

djanowski avatar djanowski commented on July 25, 2024

This issue will be fixed when this branch is merged to master: http://github.com/ezmobius/redis-rb/tree/new_protocol. In the meantime, can you test with that branch and see if it works for you?

from redis-rb.

djanowski avatar djanowski commented on July 25, 2024

We made a temporary fix on 004e7a7. Will try to get a new point release soon with this and other fixes. We only added get because delete is deprecated in favor of the native del.

from redis-rb.

djanowski avatar djanowski commented on July 25, 2024

Master no longer uses method_missing, although it's there in order to support not-yet-declared commands.

from redis-rb.

aconbere avatar aconbere commented on July 25, 2024

Awesome sauce, no more redis.call_command ["get", key] we'll check it out this week.

from redis-rb.

djanowski avatar djanowski commented on July 25, 2024

get should be working as well on 1.0.5 and 1.0.6.

from redis-rb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.