Comments (3)
Please use the beta version on our repo until we can do a release on WotrdPress.org. It's been fixed in that version.
from redux-framework.
Thanks @kprovance for prompt reply. As I can see, the previous change was adding the unit in the value, and if that was the intended implementation, the below change can help with this.
Change from:
el.find( '.redux-dimensions-input' ).on(
'change',
function() {
var units = $( this ).parents( '.redux-field:first' ).find( '.field-units' ).val();
if ( 0 !== $( this ).parents( '.redux-field:first' ).find( '.redux-dimensions-units' ).length ) {
units = $( this ).parents( '.redux-field:first' ).find( '.redux-dimensions-units option:selected' ).val();
}
if ( 'undefined' !== typeof units ) {
el.find( '#' + $( this ).attr( 'rel' ) ).val( $( this ).val() + units );
} else {
el.find( '#' + $( this ).attr( 'rel' ) ).val( $( this ).val() );
}
}
);
Change to:
el.find( '.redux-dimensions-input' ).on(
'change',
function() {
var dimension_unit = $( this ).parents( '.redux-field:first' ).find( '.field-units' ).val(),
dimention_value = $( this ).val(),
dimention_unit_el = $( this ).parents( '.redux-field:first' ).find( '.redux-dimensions-units' ),
dimention_units = dimention_unit_el.children('option').map(function(i, e){
return e.value || e.innerText;
}).get();
if ( 0 !== dimention_unit_el.length ) {
dimension_unit = $( this ).parents( '.redux-field:first' ).find( '.redux-dimensions-units option:selected' ).val();
}
// Loop through all units, and check and remove every instance of each unit found in dimension value
dimention_units.forEach(function(unit) {
var regex = new RegExp(unit, 'g');
dimention_value = dimention_value.replace(regex, '');
});
if ( 'undefined' !== typeof dimension_unit ) {
el.find( '#' + $( this ).attr( 'rel' ) ).val( dimention_value + dimension_unit );
} else {
el.find( '#' + $( this ).attr( 'rel' ) ).val( dimention_value );
}
}
);
from redux-framework.
I've already fixed it. I'm not sure of the point of this. Also, you didn't single a single piece of information I asked for when you opened the ticket, which is frowned upon. Regardless, this fix is ready
from redux-framework.
Related Issues (20)
- Multilingual social media profiles HOT 1
- Check for object before assigning
- cannot click on pages HOT 1
- Can't change the home screen logo and colours of the theme HOT 1
- Unable to add variable products from woocommerce to my cart
- v4.4.10 - Undefined Variable $return in class-redux-filesystem.php
- Thecappa Theme - Animations can't be turned off HOT 1
- 4.4.10 Redux Upgrade - Fatal error HOT 1
- How to set default values for typography field with Redux::set_option? HOT 1
- change redux default values on child theme HOT 4
- Warning count display Nan on left side for color menu HOT 1
- Attribute not working with text field HOT 4
- WordPress Backend is buggy HOT 6
- Backend is buggy- No Field ID is set HOT 8
- Project Icon Category Type Not Change HOT 1
- Bug on switch or button_set fields while in tab and zero/false value HOT 2
- Repeater extension : create unique ID for each entry HOT 1
- Theme options resets and show default values after avg (1min) of editing in wp customizer HOT 6
- header logo did'nt change
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redux-framework.