GithubHelp home page GithubHelp logo

ConnectedComponent about react-redux HOT 5 CLOSED

reduxjs avatar reduxjs commented on April 27, 2024
ConnectedComponent

from react-redux.

Comments (5)

gaearon avatar gaearon commented on April 27, 2024

Inheritance is discouraged in React code and should always be avoided for components. Composition solves the same problem in a way that is much easier to maintain.

Consider this:

  1. You'd have to remember to call super from lifecycle hooks, or component would break in a weird way.

  2. If React Redux starts to use a new lifecycle hook in its internal implementation, your existing code might break even if it worked before, because you might have been forgetting to call super.

  3. Name clashes. What if you name your method handleChange? You're going to overwrite my method. Oops!

  4. What if every utility component behaved this way? We can't have more than one base class.

In short, inheritance brings a bunch of problems, and doesn't have any advantages to composition in case of React components. Don't use it.

from react-redux.

dmitry-zaets avatar dmitry-zaets commented on April 27, 2024

Thanks for a good explanation! Will avoid using it in such way!
Just wanted to make using of connectors more transparent than 'connector(select)(Component)' calls. But I think that's wrong way:)

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

If you want a neater syntax you can use ES7 decorators proposal implemented by Babel.
Note that it's experimental and may change.

@connect(select)
export default class MyComponent { }

from react-redux.

dmitry-zaets avatar dmitry-zaets commented on April 27, 2024

Thanks, I've already noticed that in examples, but still want to avoid using experimental ES7 parts.

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

A few more comments on React, inheritance and composition:

facebook/react#613 (comment)
facebook/react#613 (comment)
facebook/react#613 (comment)

from react-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.