GithubHelp home page GithubHelp logo

Comments (5)

gaearon avatar gaearon commented on April 27, 2024 1

This is facebook/react#2517 showing its head again.
The easy fix is to always pass props down when the router state changes.

Instead of:

Router.run(routes, Router.HistoryLocation, (Handler) => {
  React.render(
    <Provider store={store}>
      {() => <Handler />}
    </Provider>, document.getElementById('root'));
});

write

Router.run(routes, Router.HistoryLocation, (Handler, props) => { // note "props" here
  React.render(
    <Provider store={store}>
      {() => <Handler {...props} />} // note "props" here
    </Provider>, document.getElementById('root'));
});

We need to document this.

I think this shouldn't affect React Router 1.0 but if you could verify this, it would be nice.

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

It's a very vague description :-). Can you publish a reproducible example?

from react-redux.

smashercosmo avatar smashercosmo commented on April 27, 2024

@gaearon Ok) Here is an example

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

Documented in d4ae7b4.

from react-redux.

smashercosmo avatar smashercosmo commented on April 27, 2024

thx for the clarification)

from react-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.