GithubHelp home page GithubHelp logo

Comments (8)

gaearon avatar gaearon commented on April 27, 2024

Important note: if mapDispatchToProps.length < 2, mapDispatchToProps should not be called on prop change.

Similarly, if mapStateToProps.length < 2 or mergeProps.length < 3, componentWillReceiveProps should not result in their recalculation, respectively.

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

cc @jhollingworth, @danharper, @ForbesLindesay who wanted to make this happen

from react-redux.

jhollingworth avatar jhollingworth commented on April 27, 2024

Happy to implement this if no one else is

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

Feel free to!

from react-redux.

PSpSynedra avatar PSpSynedra commented on April 27, 2024

@Gaeron What is the current state of this issue?
We were just updating to redux 1.0.x and have serious problems with props not being available to mapStateToProps. The reason is that we pass memoized selector functions via props that select the desired childProperties from the state.
As a workaround we could select the whole state and thus have it passed to the mergeProps callback. The problem using this workaround is, that the potentionally expensive mergeProps becomes the mapStateToProps and is callled much to often (the recomputeState is actually called for every state change in the redux store, no matter what part of the state was influenced by the change).

from react-redux.

imevro avatar imevro commented on April 27, 2024

@PSpSynedra #59 (comment)

from react-redux.

PSpSynedra avatar PSpSynedra commented on April 27, 2024

@theaqua, Yeah I just saw it :-) Looking forward to it already.

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

Released in 0.9.0, please verify.

from react-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.