GithubHelp home page GithubHelp logo

Maintain static functions about react-redux HOT 10 CLOSED

reduxjs avatar reduxjs commented on April 27, 2024
Maintain static functions

from react-redux.

Comments (10)

gaearon avatar gaearon commented on April 27, 2024

I wouldn't do that. It's only going to make things worse IMO: acdlite/flummox#173 (comment)

from react-redux.

erikras avatar erikras commented on April 27, 2024

Good call. I briefly looked into implementing it and the code disgusted me.

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

I'm happy to reconsider it using https://github.com/mridgway/hoist-non-react-statics since we don't have to maintain it. Wanna make a PR?

from react-redux.

erikras avatar erikras commented on April 27, 2024

I was going to complain about the lack of docs for that library, but then I saw how utterly trivial the code is. Also, I can't remember the time I last used the word "hoist"; such a good word.

Will add the PR to the todo list.

from react-redux.

erikras avatar erikras commented on April 27, 2024

I just, by chance, ran into a problem in my app where I need this functionality. Any chance of a release soon?

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

Give me a few days, vacation :-)

from react-redux.

esamattis avatar esamattis commented on April 27, 2024

If in hurry you can do it in userland:

MyComponentConnected = hoistNonReactStatics(connect(mapState)(MyComponent), MyComponent);

It should be future compatible.

from react-redux.

erikras avatar erikras commented on April 27, 2024

You and your pink crocs enjoy your vacation. No hurry. 🐚 🌊 ☀️

For now I've just done MyComponent.WrappedComponent.onEnter to get to my onEnter function.

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

Out in 3.1.0.

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

Lol. I knew this is going to come back and bite me in the arse.
#163 (comment)

from react-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.