GithubHelp home page GithubHelp logo

Comments (3)

gnoff avatar gnoff commented on April 27, 2024

We would need to do more than disable the warning, the Provider render method would need to be updated to conditionally call children in react 13 and simply render children in react 14. I'm not actually sure how to detect the react version at runtime, I suppose it is possible but it's more likely that we will just wait to release a version bump when 14 comes out that has a strict peer dependency on react 14 along with the api improvement.

Can't speak for Dan though so who knows.

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

I'm happy to accept a PR doing this, but I'm also not sure about “checking React version” bit (and whether we even want to attempt doing this).

I'd rather release a version depending hard on 0.14+ once it comes out, that has the right behavior. Feel free to submit a PR to implement this behavior so we can merge it once React 0.14 is out.

from react-redux.

gaearon avatar gaearon commented on April 27, 2024

Let's track this in #70.

from react-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.