GithubHelp home page GithubHelp logo

Comments (8)

borisrorsvort avatar borisrorsvort commented on August 17, 2024 3

@sdhull I added your solutions in the pr #75

from turbolinks-compatibility.

sdhull avatar sdhull commented on August 17, 2024 1

@andyrsmith Uhh yeah here you go:
facebook
twitter

from turbolinks-compatibility.

reed avatar reed commented on August 17, 2024 1

I'll review anything you submit.

from turbolinks-compatibility.

andyrsmith avatar andyrsmith commented on August 17, 2024

I would vote for starting a new repo so that people using the old version of turbolinks still have this as a resources.

Do you have your twitter & FB solutions up so I can look at them?

from turbolinks-compatibility.

borisrorsvort avatar borisrorsvort commented on August 17, 2024

@sdhull Would you have an example with loading a timeline widget? Also does it work with the back button.
For the only I manage to make it work is to disable turbolinks cache for these pages

from turbolinks-compatibility.

sdhull avatar sdhull commented on August 17, 2024

@borisrorsvort not sure what you mean by "a timeline widget"? Is there something specific you're trying to make work?

It's been on my to-do list to do something about this, either open a PR on this repo or start a new repo. I'm inclined to open a PR here as long as @reed is still interested in reviewing & accepting PRs here.

from turbolinks-compatibility.

borisrorsvort avatar borisrorsvort commented on August 17, 2024

@reed @andyrsmith can we have another branch for T5 and at some point make the switch when T5 will be mainstream. Second option would be to create another turbolinks-classic-compatibility with this content to follow the official Turbolinks convention.

@sdhull Main problems I have now with twitter timelines (https://dev.twitter.com/web/javascript/creating-widgets#create-timeline) are with the back button behaviour, as it leaves an empty iframe.

from turbolinks-compatibility.

sdhull avatar sdhull commented on August 17, 2024

@borisrorsvort ok when I get home from work today I'll check out the timelines widget.

As for a T5 branch, I'm thinking instead that since this is a gh pages project, we should instead perhaps just add a section for turbolinks 5, or something like that. Add it 5/4 to the navigation.

from turbolinks-compatibility.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.