Comments (2)
Should such a construction be considered a sound usage of
NotNan::new_unchecked
?
Yes, this is sound because it cannot violate any invariants of the unsafe code in this crate. All of the unsafe blocks are in methods that apply only to types that implement Float
.
If not, is there a reason not to add a
T: Float
bound to statically prohibit it?
There‘s no soundness reason to add such a bound. There‘s no real reason not to add the bound either; it just doesn‘t have any effect except on trivial code that does nothing with the constructed value.
from rust-ordered-float.
Thanks for the answer. Context on why I asked which may be interesting:
I have a need to construct NotNan<f32>
in const
values, and for that purpose I've defined a macro notnan!
which can only construct valid NotNan
s by virtue of only syntactically accepting literals; the simplest possible macro_rules
implementation accepts any literal and can therefore produce non-numeric NotNan
s, and I was wondering whether that was a soundness issue or harmless. Of course, it's arguably more user-friendly and robust against future language changes to reject them anyway.
At some point I may get around to preparing that macro as a PR for this crate. (Of course, future expansions of const evaluation in Rust may make NotNan::new(1.234).unwrap()
possible to write in const
context, thus making it of less value, but the macro has the arguable advantage of making it statically impossible to cause a panic.)
from rust-ordered-float.
Related Issues (20)
- Possible regression: Updating 2.8.0 to 2.9.0 causes "type annotations needed" for `BTreeSet::range` etc. HOT 5
- OrderedFloat should implement the trait Into. HOT 1
- Release Request: Please release v3.1.0 to include #110 HOT 2
- Optimize the representation of `NotNaN` HOT 2
- `rand` types missing traits
- Missing `FloatConst` trait HOT 1
- Missing `Pow` trait
- `OrderedFloat` and `NotNan` should implement `geo::HasKernel` (behind feature)
- Implement `AsPrimitive<NotNan<T>>` for integer types HOT 2
- Support checked ops.
- Implement `simba::scalar::SubsetOf` for `OrderedFloat`
- Build of v3.9.0 fails with `--feature=rkyv` HOT 3
- Changelog or a clear list of breaking changes between releases? HOT 1
- Invalid Hash implementation HOT 5
- OrderedFloat comparison with f32/f64 is not total HOT 1
- Missing binary op implementations for `OrderedFloat` HOT 2
- OrderedFloat does not implement Deserialize HOT 1
- Div by zero produces NotNan(inf) HOT 1
- Support approx?
- Implementation of `NotNan::cmp` is unsound HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-ordered-float.