GithubHelp home page GithubHelp logo

Comments (5)

sindresorhus avatar sindresorhus commented on May 21, 2024

https://github.com/{RepositorieName}/{RepositorieName}/tree/feature/BA-1234

I doubt this is correct, you've listed the repo name twice.

from refined-github.

sindresorhus avatar sindresorhus commented on May 21, 2024

Our parsing probably doesn't take into account branch names with / in them. Would you be interested in looking into a fix?

from refined-github.

paulmolluzzo avatar paulmolluzzo commented on May 21, 2024

I can do this one. If @fvelasco1 is working on it already LMK

from refined-github.

sindresorhus avatar sindresorhus commented on May 21, 2024

@paulmolluzzo Go ahead :)

from refined-github.

paulmolluzzo avatar paulmolluzzo commented on May 21, 2024

OK, I see the issue, which is totally different than we were thinking. The issue is not the string splitting, and my Regex fix branch is off base. (Sorry about that.)

The issue is that if you're merging a PR in your own repo there is no username in the blocks at the top, so there's no branch name to show.

@fvelasco1 can you please confirm you're noticing this on a repo you have push access to? (i.e. not a fork).

If that's the case it should really be that we test for the length of parts inside linkifyBranchRefs and assign accordingly. I'll be doing this in the same branch.

from refined-github.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.