Comments (7)
A couple of issues with that:
- stable or not, if it's tagged, generally you can install it, or expect it to appear soon in the non-beta version
- the feature targets tags, which are widely used, not github releases, which are the only ones with the "pre-release" flag
I donβt think I want to overcomplicate this with logic that may vary across repos. The feature answers that question alone and it can't afford to make guesses around which tag the user prefers to see.
Considering that probably there isn't even an API for this (i.e. get the tags that contain this commit), we can't even begin to consider releases.
from refined-github.
Thanks for your help and support! Yes, I do see that this is blocked by a technical limitation that the current Github REST API lacks something like git name-rev
.
A side note is that, if this feature worked as you intended (as in #7208) then it should have shown "v0.9.0" instead of "nightly". So it's the same issue as #7208 -- nightly
is shown because it is the alphabetically (not chronologically) the first tag that contains the commit, coming earlier than v...
, due to the current way how the tag information is fetched (branch_commits
). If this worked as intended, showing candidate versions, or moving tags (nightly), doesn't really matter, so I would not need this feature too in the first place. For the simplicity, not excluding the pre-release tag would be better, as you said and I can fully agree with that. All I wanted to have is to NOT see the (useless) nightly
tag; but it turns out that the reason it was showing up is not because it's a pre-release tag that had existed earlier than the full release, but because it's the lexicographically first tag.
from refined-github.
That's a misuse of tags that causes conflicts at every push/pull, see note in https://stackoverflow.com/a/19300065
nightly
should be a branch because that's that they're for.
from refined-github.
It would be even better if users can configure explicit patterns to ignore tags
We can't add options to Refined GitHub, see:
from refined-github.
I see, I understand that options are too much burden.
But I respectfully disagree that nightly
should be a branch not a tag, because "nightly releases" are "releases". Who cares a nightly tag causes a conflict? Clobbering existing tag can be easily dealth with git fetch
(no tag fetching) or git fetch --tags --force
should be of practically no problem.
UPDATE: Even if one uses a different, unique tag name for each nightly release; say nightly-20240101, closing-remarks
will still show "This PR first appeared in nightly-20240101" which is still not useful information, as the version is a "pre-release" not a stable "release".
from refined-github.
The main issue is that this feature answers the question:
- has this PR been released yet?
Pre-release is literally a release. If 1.0.1-beta includes the PR, should we said "This PR hasn't been released yet"? Because that sounds like a lie/wrong.
I'd potentially classify nightly releases as releases, but maybe we can make an exception because you probably still want to release manually later.
Perhaps we can:
- exclude tags that include "nightly" in their name
- exclude tags that don't include numbers
from refined-github.
People would be mostly looking for:
- Has this PR been released yet -- in a stable release?
while some might be also interested whether the PR has appeared in any pre-release versions (e.g. snapshot versions or release candidates).
Checking the tag name/pattern such as nightly or digits would work (#7208) but this might too specific given that you don't want to allow options; there might be many corner cases. However, in Github releases there is a very clear binary signal telling: Pre-release v.s. normal/stable/full release. (See #2239, #2905, Manage releases - item 10, and Releases REST API - prerelease
boolean field) So I think excluding pre-release would make a sense, and this would have the same principle as #2905.
So my proposal is: to show either the first non-pre-release, the first pre-release as a fallback (if there is no stable release out), or both.
from refined-github.
Related Issues (20)
- `clean-conversation-sidebar`: incorrectly hides "open in workspace" HOT 2
- Show approved in pull request list HOT 3
- Customize default issue filters to exclude specific labels HOT 1
- `pull-request-hotkeys` works intermittently HOT 5
- `closing-remarks` not showing on new computer? HOT 12
- `clean-repo-tabs`: menuItem is undefined HOT 1
- Meta: Switch from Prettier to dprint for formatting HOT 2
- "Draft a new release" button is wrapped HOT 1
- Warn when the extension is mistakenly enabled everywhere HOT 1
- Prepare token FAQ on wiki
- Prevent mutation API calls if the current user does not match the token user
- `github-actions-indications` - CSS is broken HOT 1
- Breaks the new github workspaces on Issues HOT 1
- `close-out-of-view-modals` - Add support for more dropdowns/modals
- `align-issue-labels` - CI check icon is too close to the title HOT 3
- Performance issue on PRs with lots of changes (24.6.2) HOT 3
- Personal token validation in options page doesn't work for GHE HOT 3
- `close-as-unplanned` doesn't reset to correct text after sending a comment HOT 2
- `list-prs-for-file`: Drop down covered by code view HOT 1
- `restore-file`: Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from refined-github.