Comments (9)
Maybe have set of recipients that received the emit request have been passed to? The first store that receives an emit will create and sign the recipient set with its own instance and then pass onto the next store. If a store finds its 'signature' (instance) on the recipient set, then there's an illegal cycle.
from refluxjs.
Instead of a store's instance, have an integer id
. createStore
would just assign and increment an integer id
for every new store.
from refluxjs.
Sounds like you have a plan @dashed 👍 ;-)
from refluxjs.
The test is basically testing that you can't chain two stores in a circular loop and also that you can't chain the store with itself (which is the tiniest loop possible). Sample:
// throwingErrorDuringCircularLoop.spec.js or something
describe('when a store is created', function() {
var store1;
beforeEach(function() {
store1 = Reflux.createStore({});
});
it('should fail when it listens to itself', function() {
store1.listenTo(store1, _.noop);
// assert that error is thrown, which I don't remember at the moment
// how you do it in chai
});
describe('and another store is created', function() {
var store2;
beforeEach(function() {
store2 = Reflux.createStore({});
});
it('should fail when both listen to each other', function() {
store1.listenTo(store2, _.noop);
store2.listenTo(store1, _.noop);
// assert that error is thrown
});
});
});
from refluxjs.
I'm adding this feature for 0.1.6 milestone, together with #27 and #28, so Reflux will be in feature parity with facebook/flux
from refluxjs.
Let me know if you want to take this one @dashed. If not I'll probably jump on it when I have the time in the weekend.
from refluxjs.
@spoike You can take this one. I won't have time to look at it till next week Tuesday.
from refluxjs.
Been too busy with IRL stuff this weekend so I haven't had the time to look into this. Anyone is free to take a gander at it... if nobody does then I'll notify if I start working on this.
from refluxjs.
I have a solution now. Need to integrate with Reflux.all in #28 and it'll be done.
from refluxjs.
Related Issues (20)
- init not firing HOT 1
- Object doesn't support property or method 'createActions' IE 11 HOT 1
- Support of React.js v16 HOT 6
- How are keys handled if a component is attached to multiple stores with the same key? HOT 2
- Async/await pattern with async actions HOT 3
- can we have react 16.x compatibility HOT 4
- TypeError: str.listen is not a function HOT 1
- Extending Reflux Store HOT 1
- async in Server Rendering HOT 1
- TypeError: Super expression must either be null or a function, not undefined HOT 1
- setState callback not executed in store HOT 2
- setState should support callbacks, same as the typical react setState HOT 1
- reflux store this.setState callback
- Store listening to actions after dismount
- async actions return undefined instead of Promise HOT 3
- Cannot Use Reflux Components With React getDerivedStateFromProps() Static Method HOT 3
- Roadmap questions HOT 5
- react组件中获取元素节点,使用focus方法,报错focus未定义
- Feature Request: Make Reflux available for Functional Components HOT 1
- Please mark project as dead
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from refluxjs.