Comments (3)
my 2 cents here: I think actions is the place where additional validations might be useful, so what do you think if when creating actions developer can specify arg type validation, similar to propTypes
in React.
from refluxjs.
@andreypopp I wonder if it is just easier to do the function approach anyway... and add a validator composer. E.g. like this:
// composing validator
var validatorFunc = Reflux.createValidator(
Reflux.validators.isNumberIntervalOf(0, 100),
Reflux.validators.isNot(1));
// attach validator to action
var action = Reflux.createAction(validatorFunc);
Alternatively put that into the shouldEmit
hook instead.
// attach validator to action
var action = Reflux.createAction();
action.shouldEmit = validatorFunc;
Also validators may need to "throw an error" by invoking relevant action(s) for an error handling flow. Probably add that to the validator as parameter:
// ErrorAction(s) defined earlier
var validatorFunc = Reflux.createValidator(
Reflux.validators.isNot(-1, ErrorAction.wrongNumberOnTextField)
);
Does this make sense to you all?
from refluxjs.
Krawaller has implemented the passthrough on preEmit in #78 which is included in 0.1.8.
Closing this issue now, since I'm pretty sure you can use 3rd party argument matchers in javascript. So I'm dropping the idea for now until someone comes with a really good idea for validator implementation.
from refluxjs.
Related Issues (20)
- init not firing HOT 1
- Object doesn't support property or method 'createActions' IE 11 HOT 1
- Support of React.js v16 HOT 6
- How are keys handled if a component is attached to multiple stores with the same key? HOT 2
- Async/await pattern with async actions HOT 3
- can we have react 16.x compatibility HOT 4
- TypeError: str.listen is not a function HOT 1
- Extending Reflux Store HOT 1
- async in Server Rendering HOT 1
- TypeError: Super expression must either be null or a function, not undefined HOT 1
- setState callback not executed in store HOT 2
- setState should support callbacks, same as the typical react setState HOT 1
- reflux store this.setState callback
- Store listening to actions after dismount
- async actions return undefined instead of Promise HOT 3
- Cannot Use Reflux Components With React getDerivedStateFromProps() Static Method HOT 3
- Roadmap questions HOT 5
- react组件中获取元素节点,使用focus方法,报错focus未定义
- Feature Request: Make Reflux available for Functional Components HOT 1
- Please mark project as dead
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from refluxjs.