GithubHelp home page GithubHelp logo

Comments (7)

kgilmer avatar kgilmer commented on August 25, 2024

Thanks for the details @cjthompson . In this case the issue is that recent changes source app dirs from dconf rather than $XDG_DATA_DIRS, but this flatpack directory is not in the list I specify as default. I'll have to think about it a bit but leaning towards sourcing dirs from the set of the two.

from ilia.

cjthompson avatar cjthompson commented on August 25, 2024

In this case the issue is that recent changes source app dirs from dconf rather than $XDG_DATA_DIRS,

If that's the case, then I should be able to just update the configuration to fix it? Is this just a documentation problem then rather than a technical one?

edit: I used dconf-editor to change the value of app-search-paths and that fixed my issue.

from ilia.

kgilmer avatar kgilmer commented on August 25, 2024

Well ideally things should "just work" if possible. To reproduce this issue I installed a flatpack app for testing. The dependencies to flatpack causes a change to XDG_DATA_DIRS to include the desktop file path you mention above. It would be best if ilia can use that. The reason I switched away was that, as a DE, it seems possibly out of scope to mutate XDG_DATA_DIRS. But more seriously, I found that doing that on Debian Bullseye totally bricked X11 and I was unable to troubleshoot why. So, I was left feeling uneasy about anything that involved making changes there, as bricking someone's desktop is to be avoided at all costs.

from ilia.

kgilmer avatar kgilmer commented on August 25, 2024

Related PR: regolith-linux/regolith-session#5

from ilia.

kgilmer avatar kgilmer commented on August 25, 2024

The logic to determine the desktop app paths is on the critical path of dialog bring up. As such, I prefer not to introduce more things to be done if it's avoidable. Looks like I will need to read and dedupe from both lists, use a fancier datatype, or leave it to the user to ensure their paths are correct. I also want to avoid fancy cache logic. I'm thinking the best option may be just to append the flatpack path to the search paths in dconf.. I've already got one for snap desktop files 🤷

from ilia.

kgilmer avatar kgilmer commented on August 25, 2024

After digging some more into the glib docs, I found it's possible to delegate entirely to glib for desktop apps. The performance of this feels faster and in some simple testing the performance variance is much lower. I'm going w/ this new approach and will remove app-search-paths altogether unless there is some reason to revert.

from ilia.

kgilmer avatar kgilmer commented on August 25, 2024

In Regolith 2.2 ilia calls a GLIB API for getting desktop apps rather than manually sourcing from the filesystem. Please re-open this issue of app desktop file sourcing is not working as expected in 2.2.

from ilia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.