Comments (32)
Been in the hospital for the past week, and I am in no fit state to code right now. It's pretty close, but not willing to give estimates based on health
from react-markdown.
Just thought I'd let you guys know that I've started working on the next major release of react-markdown, which will switch from commonmark to markdown, thus enabling tables (among other things).
There will be some breaking changes to the API, but nothing that should take too long to fix.
from react-markdown.
+1 For tables
from react-markdown.
+1 For this
Really need the table working
from react-markdown.
https://github.com/chjj/marked this markdown parser has support for tables...
from react-markdown.
+1 for table... really need it... please please add it
from react-markdown.
from react-markdown.
+1
Can you please share the status on this ?
from react-markdown.
@rexxars Sorry to hear. Thanks for all your hard work on this.
And I'm with them ^ take care of yourself first!
from react-markdown.
The new release candidate for v3 has table support. Please read this issue for more information. Please give it a go and let me know if you encounter issues.
from react-markdown.
@rexxars As in rendering everything the same way commonmark.js
would. There are no issues in particular I'm worried about, I just know for sure that most renderers differ in one way or another. Take a look at Babelmark's examples of divergences (look for markdown-it
as a representative of CommonMark).
from react-markdown.
@tbillington Been caught up with real-life lately, but I'm going to work on react-markdown this weekend, hoping to get closer.
from react-markdown.
Yup, Github-style.
from react-markdown.
Like everyone, I hope everything going well. You do a great job and your module rocks! Looking forward to see tables implementation. Take care of yourself.
from react-markdown.
These are pretty important. Would love to see!
from react-markdown.
I'd love to support them, but commonmark does not include them in the spec. I'm going to start experimenting with an alternative markdown parser. It might take a while to complete, since it'll almost be a complete rewrite, however.
from react-markdown.
Have no gotten much farther on this. Have experimented with alternative markdown parsers, and know that it's doable, it's just a matter of getting time to do it. Right now other projects are taking up most of my time. Don't want to give out estimates for open-source work as it totally depends on how much free time I have to work on it, which varies.
from react-markdown.
This was pretty damn awesome until I almost finished what I was working on, tried to use a table, and it fell flat on its face 😢
Switched over to remarkable
and highlight.js
as seen in Facebook's own Markdown React example.
from react-markdown.
Nice to hear, but which library in particular do you intend to use, and why abandon CommonMark? Why not markdown-it
, another CM-compatible library, acknowledged by jgm, the main guy behind CM?
In my use case, if you were to use something non-CM, the difference would probably be minimal, since the only user-generated content we have is comments, which people rarely format, and the rest can be adjusted relatively easily. But what about those with gigabytes of Markdown data, which might render differently?
from react-markdown.
@jeremejevs I'll continue to maintain commonmark-react-renderer, which to be fair is pretty much where all the logic of react-markdown resides. In hindsight, I should have named this module react-commonmark
, since that's what it currently renders. Perhaps now would be a good time to fork and publish just that.
from react-markdown.
@rexxars I understand that the current implementation can and will be maintained, and that nobody is forced to switch, but it would be nice to have both CM-compatibility and tables. That lets existing users upgrade easily, and, on the religious front, we can remain invested into a proper standard.
from react-markdown.
@jeremejevs As in; being able to opt-out of non-commonmark types?
Are there any compatibility issues in particular you're worried about? For most people, I'd think that the move would result in little or no changes in the rendered output.
from react-markdown.
Just curious about the status of the implementation of tables, are any rough goals ?
from react-markdown.
Anyone with a simple use-case and just needs table support, I found react-remarkable to be a light-weight solution that's easily swappable with react-markdown
.
from react-markdown.
@rexxars Which table format would you implement, github style?
from react-markdown.
+1 for tables! thanks!
from react-markdown.
@rexxars do you have an update on this?
from react-markdown.
@rexxars Good luck with that! Don't worry about this issue and take your time. Nobody is forcing you. 😄
from react-markdown.
Agree to @dodekeract. Health should always be first priority! Thanks for all your good work.
from react-markdown.
Awesome stuff! Really need github-style table support to display some release notes in an app I'm working on. Looking forward to it!
from react-markdown.
Closing this issue to make it easier for me to keep track of pending issues.
from react-markdown.
This is great, I really need tables as well.
The other thing I noticed is that
doesn't render as expected.
from react-markdown.
Related Issues (20)
- How to append content ,not cover? HOT 2
- When using two **enclosed bold texts containing colons, react-markdown fails to correctly parse the bold syntax. HOT 3
- Please add syntax for `{.tabset} ` HOT 2
- Typescript error while using syntax hightlight part code from README.md HOT 4
- sup element rendering with remark-gfm plugin is painfully slow. HOT 7
- React 18.3.0/19.0.0 support for react-markdown ^6.0.0 HOT 2
- React-markdown isn't rendering phone number links anymore HOT 3
- rst support HOT 2
- Can't drag-over select text to copy a section HOT 3
- Headings and subheadings aren't getting rendered (NextJS 14/ChakraUI) HOT 3
- Invalid HTML syntax together with `rehype-raw` causes crash HOT 6
- Incorrect Languageless Code Block Rendering in Example HOT 12
- Identify `last-child` HOT 3
- Compatible with lower version browsers HOT 3
- TypeError: (0 , unist_util_visit__WEBPACK_IMPORTED_MODULE_1__.visit) is not a function HOT 3
- Syntex for showing underlined text HOT 3
- would it be avaliable for yarn HOT 2
- Support Automatic Link Detection and Hyperlinking HOT 4
- custom syntax and custom components are not working HOT 3
- github attached videos HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-markdown.