GithubHelp home page GithubHelp logo

Comments (12)

wooorm avatar wooorm commented on June 11, 2024 1

Ohh, managed to reproduce!

from react-markdown.

wooorm avatar wooorm commented on June 11, 2024

this is causing issues

It is not.

This is how HTML works.

from react-markdown.

github-actions avatar github-actions commented on June 11, 2024

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

from react-markdown.

ankurparihar avatar ankurparihar commented on June 11, 2024

Hey @wooorm , This is causing issues due to invalid URL.

Here's a screenshot for the comparison on your own site, please have a look.

Screenshot 2023-11-13 at 2 23 25 PM

Can you please help me with a correct URL, with parameters.

from react-markdown.

ankurparihar avatar ankurparihar commented on June 11, 2024

Never mind, I'll recreate another example. But this is breaking!

from react-markdown.

wooorm avatar wooorm commented on June 11, 2024

It is not: there might be something else broken, likely on your end, of course. Feel free to try and reproduce the actual problem

from react-markdown.

ankurparihar avatar ankurparihar commented on June 11, 2024

Ok, finally, I'm able to reproduce!

Here you can see, in the markdown I've added a normal url from official sonarqube project

Screenshot 2023-11-13 at 3 58 10 PM

You can see what's going on in network tab, the & gets converted to & and in-turn becomes an invalid query parameter.

I'm willing to contribute a fix, but I have no idea where it's getting encoded from like this.

I appreciate the effort you guys put to create the library, please help me narrow it down.

from react-markdown.

wooorm avatar wooorm commented on June 11, 2024

Paste code so I can try it out

from react-markdown.

github-actions avatar github-actions commented on June 11, 2024

Hi team! I don’t know what’s up as there’s no phase label. Please add one so I know where it’s at.

Thanks,
— bb

from react-markdown.

ankurparihar avatar ankurparihar commented on June 11, 2024

Sorry, I was out for a while,

Here's a snippet you can try -

[![Coverage](https://next.sonarqube.com/sonarqube/api/project_badges/measure?project=sonarqube&metric=coverage&token=d95182127dd5583f57578d769b511660601a8547)](https://next.sonarqube.com/sonarqube/dashboard?id=sonarqube)

from react-markdown.

wooorm avatar wooorm commented on June 11, 2024

Released in 9.0.1!

from react-markdown.

ankurparihar avatar ankurparihar commented on June 11, 2024

Awesome, thank you so much @wooorm 🙌

from react-markdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.