GithubHelp home page GithubHelp logo

Comments (9)

wooorm avatar wooorm commented on June 19, 2024 1

Object.hasOwn is intentional. Previous versions did not have it. The latest version does.
10 years ago I had browser matrix tests. Browser tests are error prone and don’t add much. Browsers nowadays are evergreen: they automatically update.
That’s why the text in the readme says: “They work in all modern browsers (essentially: everything not IE 11)”.

I don’t think we need to add a definition of every word in the readme. I think that the current description is sufficient.

from react-markdown.

JounQin avatar JounQin commented on June 19, 2024

Chrome 90 is too old, and https://remarkjs.github.io/react-markdown is only for demo usage, I don't get why should we support Chrome 90.

We require ES2022 at b67d714

from react-markdown.

github-actions avatar github-actions commented on June 19, 2024

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

from react-markdown.

github-actions avatar github-actions commented on June 19, 2024

Hi team! Could you describe why this has been marked as wontfix?

Thanks,
— bb

from react-markdown.

guoyunhe avatar guoyunhe commented on June 19, 2024

@JounQin the project's README claims:

They work in all modern browsers (essentially: everything not IE 11).

The reason why the package is not compatible to Chrome < 93 is that it uses Object.hasOwn. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn#browser_compatibility

from react-markdown.

JounQin avatar JounQin commented on June 19, 2024

They work in all modern browsers (essentially: everything not IE 11).

That depends on what modern means, we can not support Chrome v1.0 of course.

from react-markdown.

guoyunhe avatar guoyunhe commented on June 19, 2024

That depends on what modern means, we can not support Chrome v1.0 of course.

You could add more clear definition in README.

from react-markdown.

remcohaszing avatar remcohaszing commented on June 19, 2024

This project is compatible with Node.js 16 and greater. That’s an exact definition. We don’t test across a matrix of different browser versions, so we don’t define the exact meaning of modern browser.

If you need to use modern features in an older browser, you can add a polyfill for missing APIs, or transpile modern syntax using Babel.

from react-markdown.

JounQin avatar JounQin commented on June 19, 2024

You could add more clear definition in README.

Indeed, unified projects basically require non-legacy node versions, but browsers support it's not well defined.

Or maybe that section should just be removed considering #772 (comment) and #804 (comment)

cc @wooorm and @ChristianMurphy

from react-markdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.