GithubHelp home page GithubHelp logo

Comments (9)

wooorm avatar wooorm commented on May 30, 2024

You need to provide much more info. All tests are working as expected.

from remark-usage.

niftylettuce avatar niftylettuce commented on May 30, 2024

See #8

from remark-usage.

wooorm avatar wooorm commented on May 30, 2024

😨

Could you add a test case that used to fail, but now doesn't anymore, so we can prevent this in the future?

from remark-usage.

niftylettuce avatar niftylettuce commented on May 30, 2024

@wooorm not sure what I did to cause it yet tbh 😆

from remark-usage.

wooorm avatar wooorm commented on May 30, 2024

Seems to be based on the example you have it!

from remark-usage.

niftylettuce avatar niftylettuce commented on May 30, 2024

@wooorm it was because of a missing closing HTML tag in my markdown - I'm not sure how to write a test case for this. e.g. // <sub>Some foo bar baz (note the missing </sub>)

from remark-usage.

niftylettuce avatar niftylettuce commented on May 30, 2024

@wooorm can you figure out how to write a test for this? here was my example file (note the missing closing tag for </sub> at the very top

// <sub>This section is automatically rendered from [example.js](example.js).

// ### Install

// [npm][]:

console.log('sh', 'npm install -g sao');
console.log('sh', 'sao lass new-project');

// [yarn][]:

console.log('sh', 'yarn global add sao');
console.log('sh', 'sao lass new-project');

// ### Structure

console.log(
  'sh',
  require('child_process').execSync('tree new-project').toString()
);

from remark-usage.

wooorm avatar wooorm commented on May 30, 2024

Take a look at the fixtures!

  1. You don’t need to touch test/index.js, just create a new fixture directory with the correct files (look at ones already there).
  2. I’d also suggest using a name like issue-7 and linking to this issue in readme.md!
  3. Also try to use the shortest example.js possible: try to keep only the failing lines!

from remark-usage.

wooorm avatar wooorm commented on May 30, 2024

Anyway, let’s talk over on GH-8 on how to implement the fix!

from remark-usage.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.