Use captain to build about conveyor

[mwildehahn]

I need this as well to build multiple frontend images with different assets, filed: harbur/captain#31.

I think the full commit sha is more of a nice to have, I'm going to start working on a branch that uses captain.

[ejholmes]

@mhahn You can also just fork the remind101/conveyor-builder image and pass your own image as --builder.image: https://github.com/remind101/conveyor/blob/master/cmd/conveyor/worker.go#L28-L31

[mwildehahn]

yea i did that to use a more updated version of conveyor-builder but captain also provides a similar flow to circleci which is what builds all our images now, so i think its a win

[dkapanidis]

Intrigued and interested to see conveyor and captain work together. I can check the full-sha issue, would a flag-enabling option be sufficient for that?

[mwildehahn]

Yea, I think something similar to:
https://github.com/harbur/captain/blob/master/captain.go#L43
https://github.com/harbur/captain/blob/master/cmd/captain/cmd.go#L16

would work

[mwildehahn]

@Spiddy any update on this?

[mwildehahn]

@ejholmes i started looking at this last night. I had some questions about how you would recommend structuring it.

One option like you mentioned is to fork: https://github.com/remind101/conveyor/blob/master/builder/docker/bin/build and use captain instead. I wasn't sure how to integrate that into the current app structure or if i should just do it as a separate repo

[dkapanidis]

captain code is merged. It can be activated using -l flag (or --long-sha)

[mwildehahn]

thanks @Spiddy

On Mon, Feb 1, 2016 at 2:22 AM spiddy [email protected] wrote:

captain code is merged. It can be activated using -l flag (or --long-sha)

—
Reply to this email directly or view it on GitHub
#2 (comment).

[ejholmes]

@mhahn I think with long sha support, captain can just replace the shell commands that we have in ./bin/build.

[mwildehahn]

yea, i've started that here: https://github.com/lunohq/conveyor-builder-captain/blob/master/bin/build

only regression is retrying docker push 3 times, i opened: harbur/captain#34 to track adding support for that in captain

[ejholmes]

FYI, I just pulled out remind101/conveyor-builder to https://github.com/remind101/conveyor-builder. If we make any changes to the builder, that'll be the place to do it.

[mwildehahn]

Nice it felt weird inside this repo :)
On Wed, Feb 3, 2016 at 6:31 PM Eric Holmes [email protected] wrote:

FYI, I just pulled out remind101/conveyor-builder to
https://github.com/remind101/conveyor-builder. If we make any changes to
the builder, that'll be the place to do it.

—
Reply to this email directly or view it on GitHub
#2 (comment).