Support return false in transition hooks about history

[RobertKielty]

Hi Michael, I can take a look at this now.

[mjackson]

@RobertKielty Thank you!

You'll probably need to do a bit of refactoring here.

[elpete]

Etiquette question:
When someone mentions they are taking a look at an issue, is it impolite to also work on a solution?

[ryanolsonx]

I should have checked if someone was planning to work on this issue :/ That was bad etiquette on my part. I'm going to just close my pull request. Sorry about that!

[RobertKielty]

@ericlynnpeterson no, I don't think so, as long as the job gets done; Good on ya @ryanolsonx ! @mjackson are you happy with Ryan's change? To be clear, I am happy to progress with Ryan's change.

[elpete]

I think the change looks good, too. I had missed the pull request when I started working on the issue myself and I just wanted to clarify. :-)

[RobertKielty]

We're fighting over the sweeping brush :)

On 5 August 2015 at 22:00, Eric Peterson [email protected] wrote:

I think the change looks good, too. I had missed the pull request when I
started working on the issue myself and I just wanted to clarify. :-)

—
Reply to this email directly or view it on GitHub
#15 (comment).

[ryanolsonx]

Alright, well.. I'm just cleaning up some of my commits and I'll re-submit my pull request and if @mjackson likes it, he can merge it :)

[RobertKielty]

Cool.

[mjackson]

Thanks, everyone! Let's follow up in #19.