GithubHelp home page GithubHelp logo

Comments (4)

mjackson avatar mjackson commented on April 20, 2024

Hmm, interesting. What do you think about adding a flag to the options object?

var history = createHistory({
  useBeforeUnload: false
});

I'd think if you want to disable something like this you'd want to disable it for all transition hooks, so setting the option globally makes sense.

As far as listening for the pageshow event, let's get that added in a separate PR and close the router bug.

from history.

mjackson avatar mjackson commented on April 20, 2024

Personally, I would avoid it in most cases

Just re-read this. I think you're right. Maybe we make it opt-in instead in that case?

var history = createHistory({
  useBeforeUnload: true
});

from history.

agundermann avatar agundermann commented on April 20, 2024

Yeah, I'd actually prefer opt-in. Also agree with your reasoning for using an options flag.

from history.

mjackson avatar mjackson commented on April 20, 2024

Taking a look at this today. I think it makes sense to opt-in to beforeunload handling using an enhancer, ala enableQueries. It's different enough from normal transitions that I think it warrants its own API.

from history.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.